Re: [PR] Fix leadCost calculation in BooleanScorerSupplier.requiredBulkScorer [lucene]

2025-04-28 Thread via GitHub
jpountz commented on PR #14543: URL: https://github.com/apache/lucene/pull/14543#issuecomment-2834209443 No worries at all, nobody knew it was coming soon until a few days ago. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Change in behaviour of totalHitsThreshold with #14511 [lucene]

2025-04-28 Thread via GitHub
ChrisHegarty commented on issue #14561: URL: https://github.com/apache/lucene/issues/14561#issuecomment-2834259983 Thanks for the detailed explanation @jpountz. @jimczi explained similar. Closing as not an issue. -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Change in behaviour of totalHitsThreshold with #14511 [lucene]

2025-04-28 Thread via GitHub
ChrisHegarty closed issue #14561: Change in behaviour of totalHitsThreshold with #14511 URL: https://github.com/apache/lucene/issues/14561 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

2025-04-28 Thread via GitHub
mikemccand commented on PR #13923: URL: https://github.com/apache/lucene/pull/13923#issuecomment-2835240888 Merged to `main` (11.0.0) and `branch_10x` (10.3.0), and add milestone label here. Thanks @vsop-479! -- This is an automated message from the Apache Git Service. To respond to the

Re: [I] Change in behaviour of totalHitsThreshold with #14511 [lucene]

2025-04-28 Thread via GitHub
jpountz commented on issue #14561: URL: https://github.com/apache/lucene/issues/14561#issuecomment-2834173590 ```java new TopScoreDocCollectorManager(1, 5); ``` The total hits threshold is 5 here, which means that the collector should count hits at least until it can confirm tha

Re: [PR] Enabling histogram collection for PointRangeQuery [lucene]

2025-04-28 Thread via GitHub
jainankitk commented on code in PR #14560: URL: https://github.com/apache/lucene/pull/14560#discussion_r2064899907 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -330,4 +333,23 @@ static void checkMaxBuckets(int size, i

Re: [PR] Enabling point range collector always if doc values not indexed [lucene]

2025-04-28 Thread via GitHub
jainankitk commented on PR #14559: URL: https://github.com/apache/lucene/pull/14559#issuecomment-2836900826 > My mental model is that this collector works on doc values in the default case, and can opportunistically take advantage of index statistics or points indexes when it makes things f

Re: [PR] Adding profiling support for concurrent segment search [lucene]

2025-04-28 Thread via GitHub
github-actions[bot] commented on PR #14413: URL: https://github.com/apache/lucene/pull/14413#issuecomment-2837101067 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Multireader Support in Searcher Manager [lucene]

2025-04-28 Thread via GitHub
github-actions[bot] commented on PR #13976: URL: https://github.com/apache/lucene/pull/13976#issuecomment-2837101314 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [I] Change in behaviour of totalHitsThreshold with #14511 [lucene]

2025-04-28 Thread via GitHub
ChrisHegarty commented on issue #14561: URL: https://github.com/apache/lucene/issues/14561#issuecomment-2834360107 Elasticsearch test update - https://github.com/elastic/elasticsearch/pull/127343/commits/77dc7f8a62f444730d41c4f1eb64ae59a5054faa -- This is an automated message from the Apa

[PR] Fix flaky test in TestMergeSchedulerExternal [lucene]

2025-04-28 Thread via GitHub
dweiss opened a new pull request, #14562: URL: https://github.com/apache/lucene/pull/14562 Fixes #13547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] Enabling histogram collection for PointRangeQuery [lucene]

2025-04-28 Thread via GitHub
jpountz commented on code in PR #14560: URL: https://github.com/apache/lucene/pull/14560#discussion_r2063582045 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -330,4 +333,23 @@ static void checkMaxBuckets(int size, int

Re: [PR] Enabling point range collector always if doc values not indexed [lucene]

2025-04-28 Thread via GitHub
jpountz commented on PR #14559: URL: https://github.com/apache/lucene/pull/14559#issuecomment-2835167180 I'd rather not do it. My mental model is that this collector works on doc values in the default case, and can opportunistically take advantage of index statistics or points indexes when

Re: [PR] Remove TODO in FSTCompiler#freezeTail. [lucene]

2025-04-28 Thread via GitHub
mikemccand merged PR #13923: URL: https://github.com/apache/lucene/pull/13923 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

Re: [I] Flaky Test in TestMergeSchedulerExternal#testSubclassConcurrentMergeScheduler [lucene]

2025-04-28 Thread via GitHub
dweiss commented on issue #13547: URL: https://github.com/apache/lucene/issues/13547#issuecomment-2835018138 Your analysis is absolutely correct, @aoli-al ! I'd like to apologize for the delay, this slipped from the radar somehow. I've filed a pull request that bypasses getConfig() and sync

Re: [PR] Speed up flush of softdelete by intoBitset [lucene]

2025-04-28 Thread via GitHub
gf2121 commented on PR #14552: URL: https://github.com/apache/lucene/pull/14552#issuecomment-2835371848 Hi @jpountz , may i have your opinion on this optimization? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] Add a Faiss codec for KNN searches [lucene]

2025-04-28 Thread via GitHub
kaivalnp commented on PR #14178: URL: https://github.com/apache/lucene/pull/14178#issuecomment-2835496582 > One big part of the complexity of building these packages is the low-level optimizations based on which "bare metal" you are running on > but how do I know whichever I pick is o

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

2025-04-28 Thread via GitHub
ChrisHegarty commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2063884540 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abst

Re: [PR] Fix flaky test in TestMergeSchedulerExternal [lucene]

2025-04-28 Thread via GitHub
dweiss merged PR #14562: URL: https://github.com/apache/lucene/pull/14562 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

Re: [I] Flaky Test in TestMergeSchedulerExternal#testSubclassConcurrentMergeScheduler [lucene]

2025-04-28 Thread via GitHub
dweiss closed issue #13547: Flaky Test in TestMergeSchedulerExternal#testSubclassConcurrentMergeScheduler URL: https://github.com/apache/lucene/issues/13547 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Fix flaky test in TestMergeSchedulerExternal [lucene]

2025-04-28 Thread via GitHub
dweiss commented on PR #14562: URL: https://github.com/apache/lucene/pull/14562#issuecomment-2836224601 I've backported this to branch_10x and branch_9_12. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [I] Flaky Test in TestMergeSchedulerExternal#testSubclassConcurrentMergeScheduler [lucene]

2025-04-28 Thread via GitHub
dweiss commented on issue #13547: URL: https://github.com/apache/lucene/issues/13547#issuecomment-2836236473 Thank you again, @aoli-al, this is a great contribution and not an easy test bug to track down. -- This is an automated message from the Apache Git Service. To respond to the messa

Re: [PR] Create file open hints on IOContext to replace ReadAdvice [lucene]

2025-04-28 Thread via GitHub
jpountz commented on code in PR #14482: URL: https://github.com/apache/lucene/pull/14482#discussion_r2064548591 ## lucene/core/src/java/org/apache/lucene/store/Directory.java: ## @@ -79,6 +83,31 @@ public abstract class Directory implements Closeable { */ public abstract

Re: [I] Add `SkipIndex` in SortedNumericDocValuesSetQuery [lucene]

2025-04-28 Thread via GitHub
msfroh commented on issue #14551: URL: https://github.com/apache/lucene/issues/14551#issuecomment-2836112854 Yeah -- that should be doable. My intuition is that we would need to keep the min/max values from the `SortedNumericDocValuesSetQuery`, then apply similar skipping logic to ran

Re: [PR] Enabling histogram collection for PointRangeQuery [lucene]

2025-04-28 Thread via GitHub
jainankitk commented on code in PR #14560: URL: https://github.com/apache/lucene/pull/14560#discussion_r2064779095 ## lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java: ## @@ -330,4 +333,23 @@ static void checkMaxBuckets(int size, i