jpountz commented on PR #14559: URL: https://github.com/apache/lucene/pull/14559#issuecomment-2835167180
I'd rather not do it. My mental model is that this collector works on doc values in the default case, and can opportunistically take advantage of index statistics or points indexes when it makes things faster. So doc values should be required, and index statistics and point indexes should be optional. Plus it would be confusing to me that the same collector would work or fail dependin on the specific query impl that is used, e.g. working with a PointRangeQuery on the same field (thanks to your other PR) but not on a PointRangeQuery on another field that has the same values for every doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
