jainankitk commented on PR #14559:
URL: https://github.com/apache/lucene/pull/14559#issuecomment-2836900826
> My mental model is that this collector works on doc values in the default
case, and can opportunistically take advantage of index statistics or points
indexes when it makes things faster. So doc values should be required, and
index statistics and point indexes should be optional.
+1, except that it works today even when doc_values are not indexed and that
too in some cases depending on the bucket width. Maybe to address both the
inconsistencies we have discussed, let us move the below check before using
points index for collection?
```
if (fi.getDocValuesType() != DocValuesType.NUMERIC
&& fi.getDocValuesType() != DocValuesType.SORTED_NUMERIC) {
throw new IllegalStateException(
"Expected numeric field, but got doc-value type: " +
fi.getDocValuesType());
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
