dweiss commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2823279050
> I don't understand this one: their language server works fine with java 24
and i'm able to navigate the new JDK24 classfile api, etc. I guess I haven't
used it extensively, due to the g
dweiss commented on PR #14540:
URL: https://github.com/apache/lucene/pull/14540#issuecomment-2823322410
Ok, so here's how to work this out. First, show what's bringing in the
conflicting dependencies, like the message shows:
```
./gradlew :lucene:benchmark:dependencyInsight --depen
dweiss closed issue #14508: Tone down
TestIndexWriterDelete.testDeleteAllRepeated (OOMs sometimes)
URL: https://github.com/apache/lucene/issues/14508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
dweiss merged PR #14526:
URL: https://github.com/apache/lucene/pull/14526
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
jpountz commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2056836360
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
github-actions[bot] commented on PR #14267:
URL: https://github.com/apache/lucene/pull/14267#issuecomment-2825838739
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #14131:
URL: https://github.com/apache/lucene/pull/14131#issuecomment-2825838798
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
rmuir commented on issue #14506:
URL: https://github.com/apache/lucene/issues/14506#issuecomment-2824924310
thanks for looking into this @dweiss !
I've got a PR to hopefully reduce the number of dependabot PRs for python
and actions dependencies, since some of them release very often
gf2121 commented on PR #14529:
URL: https://github.com/apache/lucene/pull/14529#issuecomment-2824954402
I personally prefer not to eagerly load docs for advance/advanceExact, or
maybe leave it to another issue/PR.
I update code to one of the version during my local iteration, which r
jpountz commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2056783050
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##
@@ -53,11 +63,31 @@ public LeafCollector getLeafCollector(LeafR
jainankitk commented on code in PR #14516:
URL: https://github.com/apache/lucene/pull/14516#discussion_r2056713597
##
lucene/core/src/java/org/apache/lucene/util/SloppyMath.java:
##
@@ -178,6 +178,30 @@ public static double asin(double a) {
}
}
+ // some sloppyish stu
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2056686537
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##
@@ -53,11 +65,30 @@ public LeafCollector getLeafCollector(Le
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2056834941
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##
@@ -53,11 +63,31 @@ public LeafCollector getLeafCollector(Le
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055497713
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
dweiss merged PR #14505:
URL: https://github.com/apache/lucene/pull/14505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055502471
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
dweiss merged PR #14503:
URL: https://github.com/apache/lucene/pull/14503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
thecoop commented on code in PR #14518:
URL: https://github.com/apache/lucene/pull/14518#discussion_r2055485408
##
lucene/core/src/test/org/apache/lucene/document/TestDocument.java:
##
@@ -312,21 +324,21 @@ public void testFieldSetValue() throws Exception {
// ensure that
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055496607
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
stefanvodita commented on PR #14498:
URL: https://github.com/apache/lucene/pull/14498#issuecomment-2823469274
Thanks David! I've enabled debug mode. I'll push and have a look at the
logs, then disable debug mode again if nothing seems out of place.
--
This is an automated message from the
stefanvodita merged PR #14498:
URL: https://github.com/apache/lucene/pull/14498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
rmuir commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055620022
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract lo
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055636449
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
rmuir commented on PR #14518:
URL: https://github.com/apache/lucene/pull/14518#issuecomment-2823693691
my concern wasn't about verbosity: if you are concerned about this, steer
clear of java!
instead just keeping "barrier to entry" to understanding the tests low. This
includes requir
ChrisHegarty commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055674573
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abst
rmuir commented on code in PR #14516:
URL: https://github.com/apache/lucene/pull/14516#discussion_r2055723991
##
lucene/core/src/java/org/apache/lucene/util/SloppyMath.java:
##
@@ -178,6 +178,30 @@ public static double asin(double a) {
}
}
+ // some sloppyish stuff, d
rmuir commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2823753882
This test is old, i think. The background IIRC is that for some Directory
impls (e.g. NIOFSDirectory or others that use "buffered input"), `clone()` may
cause at minimum a 1KB read/bu
dweiss commented on issue #14506:
URL: https://github.com/apache/lucene/issues/14506#issuecomment-2823987442
So this would require some more extensive restructuring of workflows. A
commit from within a workflow won't trigger the same set of checks (this is
done to avoid endless loops in di
dweiss closed issue #14506: Run a workflow on dependabot's PRs (gradlew
updateLicenses writeLocks)
URL: https://github.com/apache/lucene/issues/14506
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2056374094
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2056382795
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
stefanvodita commented on PR #14447:
URL: https://github.com/apache/lucene/pull/14447#issuecomment-2823807598
Sorry, I don't know if I was clear enough. I was asking if we can also
revert the change to `Lucene101PostingsWriter` and only change
`Lucene103PostingsWriter` this time.
Tha
bugmakerr commented on PR #14447:
URL: https://github.com/apache/lucene/pull/14447#issuecomment-2823829947
> Sorry, I don't know if I was clear enough. I was asking if we can also
revert the change to `Lucene101PostingsWriter` and only change
`Lucene103PostingsWriter` this time.
>
gf2121 commented on PR #14333:
URL: https://github.com/apache/lucene/pull/14333#issuecomment-2824644842
Hi @stefanvodita
We plan to allow CI chew on this change for a couple of weeks and backport
it if everything goes well. See
https://github.com/apache/lucene/pull/14333#issuecommen
stefanvodita commented on PR #14333:
URL: https://github.com/apache/lucene/pull/14333#issuecomment-2824654704
You anticipated my concern with #14447 😄
Thank you for handling this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
gf2121 merged PR #14547:
URL: https://github.com/apache/lucene/pull/14547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
jpountz commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055940755
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
jpountz commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055940755
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
mikemccand commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2824159527
+1 to bump the clone limit to 7 so the test passes again -- clone inflation!!
`clone` is likely super cheap for `MMapDirectory`? Hmm it is the JDK
version specific `Memory
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055991981
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
mikemccand commented on PR #14439:
URL: https://github.com/apache/lucene/pull/14439#issuecomment-2824226140
This is a nice optimization, using points (if the user indexed them) to
carefully optimize counting of ranges.
> @stefanvodita - Thanks for a prompt review. Addressed most of th
jpountz commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2056150570
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##
@@ -53,11 +65,30 @@ public LeafCollector getLeafCollector(LeafR
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2056382795
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
gf2121 commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2823836350
Thanks @ChrisHegarty for git bisect and @rmuir for the context.
(I allowed myself to edit your comment to point to the correct PR.)
I knew the new trie will clone the ind
gf2121 commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2824072414
As the the added clones are cloning index file `tip` of term dictionary,
which is usually opened with mmap. I raised a fix
https://github.com/apache/lucene/pull/14547 to simply incre
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055991981
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
atris commented on PR #14525:
URL: https://github.com/apache/lucene/pull/14525#issuecomment-2824857619
@jpountz Thanks! Here is the paper: https://arxiv.org/abs/2104.08976
Note that the core inspiration of this PR's approach comes from the paper,
but the implementation diverges in cer
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055991981
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
stefanvodita merged PR #14447:
URL: https://github.com/apache/lucene/pull/14447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055706972
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
dweiss commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2823770803
I've no idea either. All I know is that if I download eclipse-jdt, it
doesn't have support for Java 24 yet. There is a milestone version which
supposedly has it - but not an official stab
jpountz commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055959591
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
jpountz commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055961207
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
gf2121 closed issue #14546: TestForTooMuchCloning: too many calls to
IndexInput.clone during TermRangeQuery: 7
URL: https://github.com/apache/lucene/issues/14546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
rmuir commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2823807465
Yeah I think "big old eclipse" lags behind, whereas the jdtls is "the
latest" and sees more usage (e.g. all VSCode users and other editors).
There's even a plugin to allow use of jdt
dweiss commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2823791230
Eclipse 4.36M1 seems to have Java 24 support in the batch compiler. This is
marked as "stable" but artifacts for this release are not on maven central yet.
--
This is an automated messa
dweiss commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2823856413
I believe they use p2 repositories for interim releases and only do a maven
push once in a quarter for stable final releases.
If this becomes a problem, we can pull ecj directly fr
gf2121 opened a new pull request, #14547:
URL: https://github.com/apache/lucene/pull/14547
closes #14546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
jpountz commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055947695
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055950140
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
benwtrent commented on PR #14543:
URL: https://github.com/apache/lucene/pull/14543#issuecomment-2824317132
🤔 seems like this is another candidate for a 10.2.1 bugfix release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
stefanvodita commented on PR #14333:
URL: https://github.com/apache/lucene/pull/14333#issuecomment-2824596025
If we think the issue last week was with the tests, should we go ahead and
back-port this change?
--
This is an automated message from the Apache Git Service.
To respond to the me
gf2121 commented on code in PR #14529:
URL: https://github.com/apache/lucene/pull/14529#discussion_r2057617346
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -491,6 +492,14 @@ public int advance(int target) throws IOException {
return doc;
dweiss commented on PR #14498:
URL: https://github.com/apache/lucene/pull/14498#issuecomment-2823456560
@stefanvodita - sorry for missing your comment, please do!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
dweiss commented on PR #14499:
URL: https://github.com/apache/lucene/pull/14499#issuecomment-2823452992
Documentation markdown-to-html dependency. Tested by comparing the output
manually (no difference).
--
This is an automated message from the Apache Git Service.
To respond to the messag
dweiss merged PR #14499:
URL: https://github.com/apache/lucene/pull/14499
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss commented on PR #14503:
URL: https://github.com/apache/lucene/pull/14503#issuecomment-2823442570
build script/ dataset download dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ChrisHegarty opened a new issue, #14546:
URL: https://github.com/apache/lucene/issues/14546
### Description
```
TestForTooMuchCloning > test FAILED
java.lang.AssertionError: too many calls to IndexInput.clone during
TermRangeQuery: 7
at
__randomizedtesting.SeedIn
thecoop commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2055496607
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
stefanvodita commented on PR #14498:
URL: https://github.com/apache/lucene/pull/14498#issuecomment-2823576204
Compare the [last run with
v5](https://github.com/apache/lucene/actions/runs/14607185573/job/40978452884)
with the [first run with
v9](https://github.com/apache/lucene/actions/runs
ChrisHegarty commented on issue #14546:
URL: https://github.com/apache/lucene/issues/14546#issuecomment-2823593983
git bisect tells me that this commit is the culprit #14380. /cc @gf2121
```
878e23f77390058b6787e0a0537de9087d1019b3 is the first bad commit
commit 878e23f77390058b
rmuir commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2823604993
I'm using https://github.com/eclipse-jdtls/eclipse.jdt.ls which, is just
this same eclipse stuff packaged in a different way?
 throw
gf2121 commented on code in PR #14529:
URL: https://github.com/apache/lucene/pull/14529#discussion_r2057680596
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -625,6 +634,29 @@ boolean advanceExactWithinBlock(IndexedDISI disi, int
target) throw
jpountz commented on code in PR #14529:
URL: https://github.com/apache/lucene/pull/14529#discussion_r2057662695
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -491,6 +492,14 @@ public int advance(int target) throws IOException {
return doc
dweiss merged PR #14518:
URL: https://github.com/apache/lucene/pull/14518
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
gf2121 commented on code in PR #14529:
URL: https://github.com/apache/lucene/pull/14529#discussion_r2057597668
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -535,6 +544,7 @@ private void readBlockHeader() throws IOException {
method = M
jainankitk commented on PR #14439:
URL: https://github.com/apache/lucene/pull/14439#issuecomment-2825127094
> Oooh those JMH benchy results are nice! Though, it's dangerous testing
only on random data -- you can draw random conclusions/results. But it's better
than no benchmark! Maybe we s
github-actions[bot] commented on PR #13253:
URL: https://github.com/apache/lucene/pull/13253#issuecomment-2825839442
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
jpountz commented on code in PR #14529:
URL: https://github.com/apache/lucene/pull/14529#discussion_r2056179949
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -535,6 +544,7 @@ private void readBlockHeader() throws IOException {
method =
dweiss commented on issue #14506:
URL: https://github.com/apache/lucene/issues/14506#issuecomment-2825119807
Yes, there is no rush with this. I think the workflows do need some love but
it's not really a high priority. I'm chipping at cleaning up gradle build to
speed it up. It's a slow pro
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2056830312
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##
@@ -53,11 +63,31 @@ public LeafCollector getLeafCollector(Le
82 matches
Mail list logo
