mikemccand commented on issue #14546: URL: https://github.com/apache/lucene/issues/14546#issuecomment-2824159527
+1 to bump the clone limit to 7 so the test passes again -- clone inflation!! `clone` is likely super cheap for `MMapDirectory`? Hmm it is the JDK version specific `MemorySegmentIndexInput` (with `SingleSegmentImpl` subclass to optimize the common case ) that is actually cloned, and it's making a new class instance, setting a few members, making a shallow copy of the actual mapped segments array, and (hmm) calling `.toString()` on the to-be-cloned `IndexInput` heh (this just returns the `resourceDescription` member). So yeah it looks quite cheap. Also, this clone cost (fixed, one-time cost per segment) is amortized away as the query + segment matches more and more hits. So crazy fast queries matching very few hits are a wee bit slower and still crazy fast, and slow queries matching many hits are not affected in any meaningful way ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
