gf2121 commented on code in PR #14532:
URL: https://github.com/apache/lucene/pull/14532#discussion_r2053874070
##
lucene/core/src/java/org/apache/lucene/search/comparators/UpdateableDocIdSetIterator.java:
##
@@ -14,20 +14,24 @@
* See the License for the specific language gover
jpountz commented on PR #14529:
URL: https://github.com/apache/lucene/pull/14529#issuecomment-2820514158
To keep things as simple as possible, I'm wondering about:
- Using a very simple/robust impl in the `SPARSE` case that moves to the
next doc in a loop until either the end of block or
gf2121 commented on PR #14529:
URL: https://github.com/apache/lucene/pull/14529#issuecomment-2820572460
Thanks for feedback,
> Using a very simple/robust impl in the SPARSE case that moves to the next
doc in a loop until either the end of block or upTo, since it should never be a
bot
quangdutran commented on issue #14515:
URL: https://github.com/apache/lucene/issues/14515#issuecomment-2820678606
Based on the detailed requirement, it seems like this is very
first-contributor-friendly. Could I take this @vigyasharma ?
My approach is:
- Return a `Optional` since the s
gf2121 commented on code in PR #14532:
URL: https://github.com/apache/lucene/pull/14532#discussion_r2053874070
##
lucene/core/src/java/org/apache/lucene/search/comparators/UpdateableDocIdSetIterator.java:
##
@@ -14,20 +14,24 @@
* See the License for the specific language gover
dweiss commented on issue #14379:
URL: https://github.com/apache/lucene/issues/14379#issuecomment-2821991038
I've bumped minJava to 24 on #14533.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
dweiss commented on PR #14518:
URL: https://github.com/apache/lucene/pull/14518#issuecomment-2821903950
I'm fine with merging this change. I don't mind if the code becomes a bit
more verbose because of it. Rob?
--
This is an automated message from the Apache Git Service.
To respond to the
rmuir commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2054469931
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract lo
dweiss commented on code in PR #14518:
URL: https://github.com/apache/lucene/pull/14518#discussion_r2054473882
##
lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java:
##
@@ -810,10 +810,7 @@ public MergeSpecification findMerges(CodecReader...
readers) throws IOExce
dweiss commented on code in PR #14518:
URL: https://github.com/apache/lucene/pull/14518#discussion_r2054478021
##
lucene/core/src/test/org/apache/lucene/util/TestArrayUtil.java:
##
@@ -113,16 +119,11 @@ public void testParseInt() throws Exception {
parseInt("0.34");
thecoop commented on PR #14482:
URL: https://github.com/apache/lucene/pull/14482#issuecomment-2821545922
@jpountz @rmuir What are your thoughts? Dependent PRs using this
functionality are linked in
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
rmuir commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2054468730
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract lo
thecoop commented on code in PR #14518:
URL: https://github.com/apache/lucene/pull/14518#discussion_r2054153636
##
lucene/core/src/test/org/apache/lucene/document/TestDocument.java:
##
@@ -233,7 +245,7 @@ public void testPositionIncrementMultiFields() throws
Exception {
Ph
benwtrent commented on code in PR #14527:
URL: https://github.com/apache/lucene/pull/14527#discussion_r2054172393
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java:
##
@@ -32,13 +33,15 @@
public class NeighborArray {
private final boolean scoresDescOrder
benwtrent commented on PR #14527:
URL: https://github.com/apache/lucene/pull/14527#issuecomment-2821413727
> Do you have anything specific in mind, that I might be missing?
I am just being cautious. I know we provide locking, etc. for the concurrent
graph builder, but maybe its taking
gf2121 commented on PR #14529:
URL: https://github.com/apache/lucene/pull/14529#issuecomment-2823007173
I'm not sure, would this cause heavy overreading in scenarios where only
advance/advanceExact is required a few times in this block? E.g. we saw
aggregation on hundreds of metrics with s
jainankitk commented on code in PR #14516:
URL: https://github.com/apache/lucene/pull/14516#discussion_r2055278522
##
lucene/core/src/java/org/apache/lucene/util/SloppyMath.java:
##
@@ -178,6 +178,30 @@ public static double asin(double a) {
}
}
+ // some sloppyish stu
thecoop commented on PR #14518:
URL: https://github.com/apache/lucene/pull/14518#issuecomment-2821367957
The focus of this PR was to change `assertTrue`/`assertFalse` to assertions
that gave what was actually wrong. The `assertEquals` are things I spotted
alongside those.
I prefer th
thecoop commented on code in PR #14518:
URL: https://github.com/apache/lucene/pull/14518#discussion_r2054146955
##
lucene/core/src/test/org/apache/lucene/util/TestArrayUtil.java:
##
@@ -113,16 +119,11 @@ public void testParseInt() throws Exception {
parseInt("0.34");
thecoop commented on code in PR #14518:
URL: https://github.com/apache/lucene/pull/14518#discussion_r2054149599
##
lucene/core/src/test/org/apache/lucene/index/TestAddIndexes.java:
##
@@ -810,10 +810,7 @@ public MergeSpecification findMerges(CodecReader...
readers) throws IOExc
weizijun commented on PR #14527:
URL: https://github.com/apache/lucene/pull/14527#issuecomment-2821532658
Yes, maybe it's not suitable for concurrent graph builders. I tested this
case in elasticsearch and it worked fine.
Probably because in elasticsearch, the merge of graph builders is i
Shibi-bala commented on PR #14524:
URL: https://github.com/apache/lucene/pull/14524#issuecomment-2821765755
@jainankitk ah linked the wrong PR. It was
https://github.com/apache/lucene/pull/13472 that made this change, and it seems
like there were considerable speedups. Though it comes at th
jainankitk commented on PR #14527:
URL: https://github.com/apache/lucene/pull/14527#issuecomment-2822073026
> I am just being cautious. I know we provide locking, etc. for the
concurrent graph builder, but maybe its taking advantage of arrays never
growing by accident.
Thanks for ela
Shibi-bala commented on PR #14524:
URL: https://github.com/apache/lucene/pull/14524#issuecomment-2822084989
This really only impacts Knn queries where the work is done in rewrite and
indexSearcher.getTaskExecutor() is called from the knn query. For all other
queries, the caller can control
jainankitk opened a new pull request, #14534:
URL: https://github.com/apache/lucene/pull/14534
### Description
Improves the user-facing docs for geo package by adding more details and
examples
--
This is an automated message from the Apache Git Service.
To respond to th
jpountz commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054847302
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Software F
Shibi-bala commented on issue #13745:
URL: https://github.com/apache/lucene/issues/13745#issuecomment-2822481473
@javanna not sure about the underlying implementation of these queries. Does
using intra-segment partitioning negatively impact these queries
(TermInSet/MultiTerm) or is there st
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054906523
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Softwar
jainankitk commented on PR #14439:
URL: https://github.com/apache/lucene/pull/14439#issuecomment-2822536135
> Interesting idea! I like that you integrated it transparently into the
collector, so that users can benefit from it out of the box.
Thanks @jpountz for the review. Had some ch
stefanvodita commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054858596
##
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/HistogramCollectorBenchmark.java:
##
@@ -0,0 +1,130 @@
+/*
+ * Licensed to the Apache Software Fo
dependabot[bot] opened a new pull request, #14541:
URL: https://github.com/apache/lucene/pull/14541
Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from
3.21.0 to 3.27.3.
Release notes
Sourced from https://github.com/assertj/assertj/releases";>org.assertj:asser
dependabot[bot] opened a new pull request, #14540:
URL: https://github.com/apache/lucene/pull/14540
Bumps org.apache.commons:commons-compress from 1.19 to 1.27.1.
[`. To do this we compute the `leadCost` first from the relevant
`ScorerSupplier`s, and then
dweiss commented on PR #14519:
URL: https://github.com/apache/lucene/pull/14519#issuecomment-2821973795
Please see #14533
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
dweiss closed pull request #14519: Upgrade to gradle 8.14-rc-2
URL: https://github.com/apache/lucene/pull/14519
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe,
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054876160
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java:
##
@@ -0,0 +1,227 @@
+/*
+ * Licensed to the Apache Softwar
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054889522
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##
@@ -53,11 +59,22 @@ public LeafCollector getLeafCollector(Le
jainankitk opened a new issue, #14535:
URL: https://github.com/apache/lucene/issues/14535
### Description
While https://github.com/apache/lucene/pull/14439 adds Histogram Collector
optimization for `MATCH_ALL` cases, it does not apply for `PointRangeQuery`
filtering out few documents
rmuir opened a new pull request, #14544:
URL: https://github.com/apache/lucene/pull/14544
pip and actions aren't the primary focus of the project, set PRs to monthly.
It should still serve the purpose of keeping dependencies up to date, while
reducing the noise (there will be less PRs). Som
rmuir merged PR #14539:
URL: https://github.com/apache/lucene/pull/14539
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #14538:
URL: https://github.com/apache/lucene/pull/14538#issuecomment-2822853500
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
rmuir commented on code in PR #14516:
URL: https://github.com/apache/lucene/pull/14516#discussion_r2055120900
##
lucene/core/src/java/org/apache/lucene/util/SloppyMath.java:
##
@@ -178,6 +178,30 @@ public static double asin(double a) {
}
}
+ // some sloppyish stuff, d
rmuir merged PR #14537:
URL: https://github.com/apache/lucene/pull/14537
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir commented on PR #14540:
URL: https://github.com/apache/lucene/pull/14540#issuecomment-2822868442
hmm I'm unable to do a `gradlew writelocks` on this branch to move this one
along. Something confusing is happening with `benchmark/` that seems to cause
just `benchmark/` to want a differ
rmuir commented on PR #14533:
URL: https://github.com/apache/lucene/pull/14533#issuecomment-2822887374
> * upgrade to an ECJ version that supports Java 24 (none yet) and revert
the enabled=false from the patch
I don't understand this one: their language server works fine with java 24
rmuir merged PR #14538:
URL: https://github.com/apache/lucene/pull/14538
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
jpountz commented on PR #14529:
URL: https://github.com/apache/lucene/pull/14529#issuecomment-2822391718
> I'm a bit confused on this, current patch has already been loading docs
into a in-memory bitset and reuse orRange, could you be more specific?
I was wondering if we should go one
jpountz commented on PR #14525:
URL: https://github.com/apache/lucene/pull/14525#issuecomment-2822409227
Can you link the paper that you implemented? I'll need some time to digest
these 5k lines. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
stefanvodita commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054837202
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Softw
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054986918
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Softwar
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054988914
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Softwar
jainankitk opened a new issue, #14536:
URL: https://github.com/apache/lucene/issues/14536
### Description
The HistogramCollector uses `PointTreeBulkCollector` logic only when the
PointTree is dense compared to the buckets across which it is getting
collected. But for cases that don't
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054996584
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Softwar
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054995845
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/PointTreeBulkCollector.java:
##
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Softwar
jpountz commented on PR #14532:
URL: https://github.com/apache/lucene/pull/14532#issuecomment-2822335175
> By 'side-effect', do you mean another gain? I thought it means negative
effects :)
Hopefully a gain, I still need to run benchmarks. This change also increases
polymorphism, so
jpountz commented on code in PR #14482:
URL: https://github.com/apache/lucene/pull/14482#discussion_r2054788526
##
lucene/core/src/java/org/apache/lucene/store/Directory.java:
##
@@ -79,6 +83,31 @@ public abstract class Directory implements Closeable {
*/
public abstract
peteralfonsi commented on PR #14543:
URL: https://github.com/apache/lucene/pull/14543#issuecomment-2822754796
Marking as draft for now, I will add a test case for this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
peteralfonsi opened a new pull request, #14543:
URL: https://github.com/apache/lucene/pull/14543
### Description
Fixes https://github.com/apache/lucene/issues/14542 by setting `leadCost` in
`BooleanScorerSupplier.requiredBulkScorer` to the minimum of both MUST and
FILTER clauses' cos
github-actions[bot] commented on PR #13072:
URL: https://github.com/apache/lucene/pull/13072#issuecomment-2822769419
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
jainankitk commented on code in PR #14439:
URL: https://github.com/apache/lucene/pull/14439#discussion_r2054894167
##
lucene/sandbox/src/java/org/apache/lucene/sandbox/facet/plain/histograms/HistogramCollector.java:
##
@@ -53,11 +65,30 @@ public LeafCollector getLeafCollector(Le
dependabot[bot] opened a new pull request, #14537:
URL: https://github.com/apache/lucene/pull/14537
Bumps [basedpyright](https://github.com/detachhead/basedpyright) from 1.28.5
to 1.29.0.
Commits
https://github.com/DetachHead/basedpyright/commit/346d286006f1830cc1f2be43e191838b
dependabot[bot] opened a new pull request, #14539:
URL: https://github.com/apache/lucene/pull/14539
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.11.5 to 0.11.6.
Release notes
Sourced from https://github.com/astral-sh/ruff/releases";>ruff's releases.
0.11.6
Releas
dependabot[bot] opened a new pull request, #14538:
URL: https://github.com/apache/lucene/pull/14538
Bumps [holidays](https://github.com/vacanza/holidays) from 0.70 to 0.71.
Release notes
Sourced from https://github.com/vacanza/holidays/releases";>holidays's
releases.
v0.71
rmuir merged PR #14541:
URL: https://github.com/apache/lucene/pull/14541
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
64 matches
Mail list logo
