gf2121 commented on PR #14529: URL: https://github.com/apache/lucene/pull/14529#issuecomment-2820572460
Thanks for feedback, > Using a very simple/robust impl in the SPARSE case that moves to the next doc in a loop until either the end of block or upTo, since it should never be a bottleneck (especially as DenseConjunctionBulkScorer is only used on dense iterators)? I won't assert `intoBitset` will only be called by `DenseConjunctionBulkScorer`. I was also thinking about using this for soft delete (https://github.com/apache/lucene/issues/14521) as well, `IndexedDISI#writeBitset` will always load the whole block of docs into a bitset. But I'm not sure how much performance this patch gains, i agree to keep it simple as a first step. > Refactoring DENSE to load doc IDs into an in-memory bit set all the time, so that intoBitSet could directly reuse FixedBitSet.orRange. I'm a bit confused on this, current patch has already been loading into a in-memory bitset and reuse `orRange`, could you be more specific? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
