[PR] Tighten up IndexSortSortedNumericDocValuesRangeQuery index sort validation [lucene]

2024-11-01 Thread via GitHub
gsmiller opened a new pull request, #13973: URL: https://github.com/apache/lucene/pull/13973 ### Description Small refactoring to remove some duplicated code around index sort loading/validation and to improve readability (IMO anyway). -- This is an automated message from the Apache Gi

Re: [PR] Avoid reload block when seeking backward in SegmentTermsEnum. [lucene]

2024-11-01 Thread via GitHub
github-actions[bot] commented on PR #13253: URL: https://github.com/apache/lucene/pull/13253#issuecomment-2452749686 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] A few small tweaks to VectorUtil#findNextGEQ [lucene]

2024-11-01 Thread via GitHub
gsmiller commented on code in PR #13972: URL: https://github.com/apache/lucene/pull/13972#discussion_r1826036633 ## lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene912/Lucene912PostingsReader.java: ## @@ -1755,13 +1755,13 @@ static long readVLong15(DataIn

Re: [PR] A few small tweaks to VectorUtil#findNextGEQ [lucene]

2024-11-01 Thread via GitHub
gsmiller commented on code in PR #13972: URL: https://github.com/apache/lucene/pull/13972#discussion_r1826037886 ## lucene/core/src/java/org/apache/lucene/codecs/lucene101/Lucene101PostingsReader.java: ## @@ -601,7 +599,7 @@ public int advance(int target) throws IOException {

Re: [PR] minor javadoc correction on VectorUtilSupport#findNextGEQ [lucene]

2024-11-01 Thread via GitHub
gsmiller commented on PR #13969: URL: https://github.com/apache/lucene/pull/13969#issuecomment-2452189489 Added an assertion and tweaked parameter naming as discussed here over in #13972. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Revert "Disjunction as CompetitiveIterator for numeric dynamic pruning (#13221)" [lucene]

2024-11-01 Thread via GitHub
javanna commented on code in PR #13971: URL: https://github.com/apache/lucene/pull/13971#discussion_r1825756810 ## lucene/core/src/java/org/apache/lucene/util/IntArrayDocIdSet.java: ## @@ -34,23 +34,15 @@ public final class IntArrayDocIdSet extends DocIdSet { private final in

Re: [PR] Revert "Disjunction as CompetitiveIterator for numeric dynamic pruning (#13221)" [lucene]

2024-11-01 Thread via GitHub
javanna commented on PR #13971: URL: https://github.com/apache/lucene/pull/13971#issuecomment-2451858027 @gf2121 pinging you explicitly because you worked on #13221. Sadly, we observed some severe regressions caused by it, and we were not able to somehow adjust the updated algorithm to avoi

Re: [PR] New JMH benchmark method - vdot8s that implement int8 dotProduct in C… [lucene]

2024-11-01 Thread via GitHub
msokolov commented on code in PR #13572: URL: https://github.com/apache/lucene/pull/13572#discussion_r1825833969 ## lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java: ## @@ -291,25 +296,125 @@ private float squareDistanceBody(float[] a,

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-01 Thread via GitHub
gsmiller commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1826241555 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points

Re: [PR] DocValuesSkipper implementation in IndexSortSorted [lucene]

2024-11-01 Thread via GitHub
gsmiller commented on code in PR #13886: URL: https://github.com/apache/lucene/pull/13886#discussion_r1826238079 ## lucene/core/src/java/org/apache/lucene/search/IndexSortSortedNumericDocValuesRangeQuery.java: ## @@ -397,106 +413,80 @@ private boolean matchAll(PointValues points

Re: [I] [Discuss] What should we name the new aggregation engine? [lucene]

2024-11-01 Thread via GitHub
msokolov commented on issue #13965: URL: https://github.com/apache/lucene/issues/13965#issuecomment-2452668213 copy-pasting from the polling site: ``` Facetron Agamemnon Analytics Count Dracula Aggie Bucketeer Gator Fusion Slurper Lustre Match-time Aggr

Re: [PR] Rename NodeHash to FSTSuffixNodeCache + Javadoc improvement [lucene]

2024-11-01 Thread via GitHub
msokolov commented on PR #13259: URL: https://github.com/apache/lucene/pull/13259#issuecomment-2452660151 Thanks, this does seem much more explicit and helpful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [I] [Discuss] What should we name the new aggregation engine? [lucene]

2024-11-01 Thread via GitHub
stefanvodita commented on issue #13965: URL: https://github.com/apache/lucene/issues/13965#issuecomment-2452683167 > Are we looking for a java package name? A name to use when saying - should I convert from facets to "xxx"? The second onw is what I have in mind. Whether this new aggre

Re: [PR] Rename NodeHash to FSTSuffixNodeCache + Javadoc improvement [lucene]

2024-11-01 Thread via GitHub
msokolov merged PR #13259: URL: https://github.com/apache/lucene/pull/13259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [I] Significant performance regression with search after [lucene]

2024-11-01 Thread via GitHub
javanna commented on issue #13856: URL: https://github.com/apache/lucene/issues/13856#issuecomment-2451717823 I opened https://github.com/apache/lucene/pull/13971 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [I] Significant performance regression with search after [lucene]

2024-11-01 Thread via GitHub
javanna commented on issue #13856: URL: https://github.com/apache/lucene/issues/13856#issuecomment-2451714216 There has been little activity on this issue, I am leaning towards applying the revert of the change that caused the regression to branch_10x and main as well. I am anxious that we