Re: [I] English grammar error in `Field that stores a per-document long values for scoring` [lucene]

cpoerschke commented on issue #13482: URL: https://github.com/apache/lucene/issues/13482#issuecomment-2167515352 Thanks @wurui90 for spotting and reporting this! Would you like to open a pull request to edit the wording? -- This is an automated message from the Apache Git Service. To resp

Re: [I] Stop double-checking priority queue inserts [lucene]

slow-J commented on issue #13175: URL: https://github.com/apache/lucene/issues/13175#issuecomment-2167958560 > Maybe we can also extract out a common function from all the `Facets` inserting into a priority queue, as @Shradha26 [suggests](https://github.com/apache/lucene/pull/12966#discussi

[PR] GITHUB#13175: Stop double-checking priority queue inserts [lucene]

slow-J opened a new pull request, #13488: URL: https://github.com/apache/lucene/pull/13488 Removing 2 cases of bottomX optimizations where insertWithOverflow already handles the check. Closes #13175 The diff looks funny because of unnesting, but, per file, I am just removing

Re: [I] `mergeThreadCount` is both a variable and a method in the `ConcurrentMergeScheduler` [lucene]

slow-J commented on issue #13114: URL: https://github.com/apache/lucene/issues/13114#issuecomment-2168007338 Another option could be renaming the method to `countMergeThreads`. Feel free to raise a PR! -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Update int array growth calls [lucene]

slow-J commented on code in PR #12947: URL: https://github.com/apache/lucene/pull/12947#discussion_r1639824058 ## lucene/core/src/java/org/apache/lucene/util/LSBRadixSorter.java: ## @@ -92,7 +92,7 @@ public void sort(int numBits, final int[] array, int len) { return;

Re: [PR] Update int array growth calls [lucene]

stefanvodita commented on code in PR #12947: URL: https://github.com/apache/lucene/pull/12947#discussion_r1639869649 ## lucene/core/src/java/org/apache/lucene/util/LSBRadixSorter.java: ## @@ -92,7 +92,7 @@ public void sort(int numBits, final int[] array, int len) { return

Re: [PR] Update int array growth calls [lucene]

slow-J commented on code in PR #12947: URL: https://github.com/apache/lucene/pull/12947#discussion_r1639906131 ## lucene/CHANGES.txt: ## @@ -217,6 +217,8 @@ Other * GITHUB#12934: Cleaning up old references to Lucene/Solr. (Jakub Slowinski) +* GITHUB#12941: Don't preserve au

[PR] Minor cleanup in some Facet tests [lucene]

slow-J opened a new pull request, #13489: URL: https://github.com/apache/lucene/pull/13489 Fixing some IDE "warnings", such as removing some dead code + fixing a link + adding use of try-with-resources. Did not fix `'search(org.apache.lucene.search.Query, org.apache.lucene.search.Col

Re: [PR] Minor cleanup in some Facet tests [lucene]

mikemccand commented on PR #13489: URL: https://github.com/apache/lucene/pull/13489#issuecomment-2169122348 > While I am already touching these, let me know if anyone has strong opinions and I can also fix the `Statement lambda can be replaced with expression lambda` or `Redundant array cre

Re: [PR] Minor cleanup in some Facet tests [lucene]

mikemccand commented on code in PR #13489: URL: https://github.com/apache/lucene/pull/13489#discussion_r1640748830 ## lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetValueSource.java: ## @@ -694,7 +694,7 @@ private void checkResults( "dim

Re: [PR] Only apply deletion one time for unique term update in FrozenBufferedUpdates.applyTermDeletes [lucene]

mikemccand commented on code in PR #13486: URL: https://github.com/apache/lucene/pull/13486#discussion_r1640752212 ## lucene/core/src/java/org/apache/lucene/index/IndexWriter.java: ## @@ -1838,6 +1838,20 @@ public long updateDocument(Term term, Iterable doc) th term ==

Re: [PR] GITHUB#13175: Stop double-checking priority queue inserts [lucene]

mikemccand commented on code in PR #13488: URL: https://github.com/apache/lucene/pull/13488#discussion_r1640756284 ## lucene/CHANGES.txt: ## @@ -273,6 +273,8 @@ Optimizations * GITHUB#13431: Replace TreeMap and use compiled Patterns in Japanese UserDictionary. (Bruno Roustan