slow-J commented on issue #13175: URL: https://github.com/apache/lucene/issues/13175#issuecomment-2167958560
> Maybe we can also extract out a common function from all the `Facets` inserting into a priority queue, as @Shradha26 [suggests](https://github.com/apache/lucene/pull/12966#discussion_r1452555874). I can't see a way to do this cleanly since e.g. `StringValueFacetCounts` uses `TopOrdAndIntQueue` while the `TaxonomyFacets` abstract class uses `TopOrdAndNumberQueue` which gets casted to int in `setIncomingValue`. If we refactored this to a util method, we would lose the ability to override `setIncomingValue` in the case of non-int queues. I'll submit a PR for the issue in the initial description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
