mikemccand commented on code in PR #13489:
URL: https://github.com/apache/lucene/pull/13489#discussion_r1640748830
##########
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/TestTaxonomyFacetValueSource.java:
##########
@@ -694,7 +694,7 @@ private void checkResults(
"dim" + i,
new String[0],
aggregatedValue,
- labelValues.toArray(new LabelAndValue[labelValues.size()]),
+ labelValues.toArray(new LabelAndValue[0]),
Review Comment:
Hmm why this change? Doesn't it mean we allocate both empty array and
correctly sized array with this change, but before we were only allocating the
one (correctly sized) array?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
