Re: [PR] Sparse index: optional skip list on top of doc values [lucene]

2024-06-13 Thread via GitHub
iverase merged PR #13449: URL: https://github.com/apache/lucene/pull/13449 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

Re: [PR] Update document by docID [lucene]

2024-06-13 Thread via GitHub
vsop-479 closed pull request #13481: Update document by docID URL: https://github.com/apache/lucene/pull/13481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

Re: [PR] Update document by docID [lucene]

2024-06-13 Thread via GitHub
vsop-479 commented on PR #13481: URL: https://github.com/apache/lucene/pull/13481#issuecomment-2165361148 Close since segment merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] gh-13340: Allow adding a parent field to an index with no fields [lucene]

2024-06-13 Thread via GitHub
kkrik-es commented on PR #13341: URL: https://github.com/apache/lucene/pull/13341#issuecomment-2165713033 Would it be possible to back-port this fix to v.9.11? I did hit this issue as well while trying to make use of #12829. -- This is an automated message from the Apache Git Service. To

Re: [PR] gh-13340: Allow adding a parent field to an index with no fields [lucene]

2024-06-13 Thread via GitHub
kkrik-es commented on PR #13341: URL: https://github.com/apache/lucene/pull/13341#issuecomment-2165959754 That would be nice, thanks. @jpountz @benwtrent fyi. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

[PR] backport #gh-13340 [lucene]

2024-06-13 Thread via GitHub
msokolov opened a new pull request, #13483: URL: https://github.com/apache/lucene/pull/13483 created a PR so github can run tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Expose FlatVectorsFormat [lucene]

2024-06-13 Thread via GitHub
msokolov commented on PR #13469: URL: https://github.com/apache/lucene/pull/13469#issuecomment-2166045890 I changed this to return zero results from search() rather than throwing `UnsupportedOperationException` to be more in line with how we treat searches over other kinds of fields that on

[PR] Gradle build: cleanup of dependency resolution and consolidation of dependency versions [lucene]

2024-06-13 Thread via GitHub
dweiss opened a new pull request, #13484: URL: https://github.com/apache/lucene/pull/13484 This patch attempts to clean up and consolidate all kinds of aspects related to dependencies used throughout the build and "versions", understood not only as dependency versions but also minimum java

Re: [PR] backport #gh-13340 [lucene]

2024-06-13 Thread via GitHub
msokolov merged PR #13483: URL: https://github.com/apache/lucene/pull/13483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] gh-13340: Allow adding a parent field to an index with no fields [lucene]

2024-06-13 Thread via GitHub
msokolov commented on PR #13341: URL: https://github.com/apache/lucene/pull/13341#issuecomment-2165955635 I don't think we can backport to 9.11 since it has already been released, but I will backport to 9.x and then it should get released with the next. There was some talk about a 9.11.1, s

Re: [PR] gh-13340: Allow adding a parent field to an index with no fields [lucene]

2024-06-13 Thread via GitHub
benwtrent commented on PR #13341: URL: https://github.com/apache/lucene/pull/13341#issuecomment-2166407167 @msokolov it might be worth doing a 9.11.1 release to fix this particular bug and maybe another other one: https://github.com/apache/lucene/pull/13475 I didn't know about this ou

Re: [PR] gh-13340: Allow adding a parent field to an index with no fields [lucene]

2024-06-13 Thread via GitHub
msokolov commented on PR #13341: URL: https://github.com/apache/lucene/pull/13341#issuecomment-2166553436 sigh, I would have backported right away except for some reason I thought the parent-field enforcement was only on 10.x not 9.x -- This is an automated message from the Apache Git Ser

Re: [PR] Expose FlatVectorsFormat [lucene]

2024-06-13 Thread via GitHub
msokolov commented on code in PR #13469: URL: https://github.com/apache/lucene/pull/13469#discussion_r1638780434 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsFormat.java: ## @@ -79,7 +79,8 @@ public final class Lucene99FlatVectorsFormat extends F

Re: [PR] Expose FlatVectorsFormat [lucene]

2024-06-13 Thread via GitHub
msokolov commented on code in PR #13469: URL: https://github.com/apache/lucene/pull/13469#discussion_r1638786155 ## lucene/codecs/src/java/org/apache/lucene/codecs/bitvectors/HnswBitVectorsFormat.java: ## @@ -128,7 +129,7 @@ public HnswBitVectorsFormat( } else { this

Re: [PR] Expose FlatVectorsFormat [lucene]

2024-06-13 Thread via GitHub
msokolov commented on PR #13469: URL: https://github.com/apache/lucene/pull/13469#issuecomment-2166643207 for the failed test here I'll add a test assumption that the randomly-selected vector format be one that supports search (ie not a FlatVectorsFormat) since the test requires that. --

Re: [PR] Fix global score update bug in MultiLeafKnnCollector [lucene]

2024-06-13 Thread via GitHub
benwtrent commented on PR #13463: URL: https://github.com/apache/lucene/pull/13463#issuecomment-212079 @gsmiller @mayya-sharipova OK, I did some more testing. My initial testing didn't fully exercise these paths as the segments were still very large. So, I switched to flushing at

Re: [PR] Expose FlatVectorsFormat [lucene]

2024-06-13 Thread via GitHub
benwtrent commented on code in PR #13469: URL: https://github.com/apache/lucene/pull/13469#discussion_r1638749258 ## lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsReader.java: ## @@ -217,6 +219,18 @@ public ByteVectorValues getByteVectorValues(String

Re: [PR] Expose FlatVectorsFormat [lucene]

2024-06-13 Thread via GitHub
msokolov merged PR #13469: URL: https://github.com/apache/lucene/pull/13469 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.ap

Re: [PR] Refactoring ShingleFilter: Final Fields, Builder Pattern, and Constructor Update [lucene]

2024-06-13 Thread via GitHub
github-actions[bot] commented on PR #13390: URL: https://github.com/apache/lucene/pull/13390#issuecomment-2166992316 This PR has not had activity in the past 2 weeks, labeling it as stale. If the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you for your contributi

Re: [PR] Fix global score update bug in MultiLeafKnnCollector [lucene]

2024-06-13 Thread via GitHub
benwtrent commented on PR #13463: URL: https://github.com/apache/lucene/pull/13463#issuecomment-2167001969 OK, I used the same methodology, but with CohereV3, 5M vectors. | fanout ->| 0 | 10| 50| 100 | 200 | |--|---|---|---|---|--

[PR] test: kuromoji [lucene]

2024-06-13 Thread via GitHub
atsushi-matsui opened a new pull request, #13485: URL: https://github.com/apache/lucene/pull/13485 ### Description -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment