iamsanjay commented on PR #13440:
URL: https://github.com/apache/lucene/pull/13440#issuecomment-2141366659
1. There were three classes that are using weight in some way so I leave
them to be for now.
`FunctionQuery#AllScorer`
https://github.com/apache/lucene/blob/750a7c4d3
carlosdelest commented on code in PR #13430:
URL: https://github.com/apache/lucene/pull/13430#discussion_r1620451379
##
lucene/core/src/java/org/apache/lucene/index/TieredMergePolicy.java:
##
@@ -93,6 +93,7 @@ public class TieredMergePolicy extends MergePolicy {
private doubl
ChrisHegarty opened a new issue, #13443:
URL: https://github.com/apache/lucene/issues/13443
```
reproduce with: gradlew test --tests
TestSimpleTextKnnVectorsFormat.testFloatVectorScorerIteration
-Dtests.seed=D5C839ED84ABC868 -Dtests.locale=kkj-Latn-CM
-Dtests.timezone=Europe/Belgrad
ChrisHegarty opened a new pull request, #13444:
URL: https://github.com/apache/lucene/pull/13444
This commit ensures that `SimpleText[Float|Byte]VectorValues::scorer`
returns null when the vector values is empty, as per the scorer javadoc. Other
KnnVectorsReader implementations have specia
jpountz commented on PR #13440:
URL: https://github.com/apache/lucene/pull/13440#issuecomment-2141925741
> We are also removing weight from Subclasses of Scorer as well, right?
Yes, that would be great. If there are a few sub classes that really need a
Weight, we could keep it, it loo
jpountz commented on PR #13440:
URL: https://github.com/apache/lucene/pull/13440#issuecomment-2141965592
> few ctors have been reduced to default ctor. Should I removed those as
well?
For those that are in the `java` folder, I'd keep them and add javadocs (I
thought the build checked
jpountz commented on issue #13442:
URL: https://github.com/apache/lucene/issues/13442#issuecomment-2141990962
Thinking out loud: I'd like queries to remain as close to value classes as
possible, just describing an information need. I believe that the change you're
suggesting would require s
ChrisHegarty commented on PR #13444:
URL: https://github.com/apache/lucene/pull/13444#issuecomment-2142165781
This commit ensures that SimpleText[Float|Byte]VectorValues::scorer returns
null when the vector values is empty, as per the scorer javadoc. Other
KnnVectorsReader implementations h
ChrisHegarty closed issue #13443: Reproducible failure
TestSimpleTextKnnVectorsFormat.testFloatVectorScorerIteration
URL: https://github.com/apache/lucene/issues/13443
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
ChrisHegarty merged PR #13444:
URL: https://github.com/apache/lucene/pull/13444
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucen
hack4chang commented on code in PR #13419:
URL: https://github.com/apache/lucene/pull/13419#discussion_r1621365979
##
lucene/core/src/test/org/apache/lucene/analysis/TestWordlistLoader.java:
##
@@ -77,4 +82,17 @@ public void testSnowballListLoading() throws IOException {
as
benwtrent opened a new pull request, #13445:
URL: https://github.com/apache/lucene/pull/13445
When int4 scalar quantization was merged, it added a new way to dynamically
calculate quantiles.
However, when that was merged, I inadvertently changed the default behavior,
where a `null`
dsmiley commented on PR #13440:
URL: https://github.com/apache/lucene/pull/13440#issuecomment-2142590119
It's not clear why Solr would care with regards to FunctionValues & Weights
in particular. I don't notice Solr using Weights there but maybe I'm not
looking in quite the right spot?
benwtrent commented on PR #13445:
URL: https://github.com/apache/lucene/pull/13445#issuecomment-2142591533
I am planning on putting this in 9.11 as it is also a fix for breaking BWC
that 9.11 currently does when using the same format configuration between 9.10
vs. 9.11. In 9.10, supplying a
14 matches
Mail list logo
