vsop-479 commented on code in PR #13192:
URL: https://github.com/apache/lucene/pull/13192#discussion_r1580673258
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/SegmentTermsEnumFrame.java:
##
@@ -196,6 +207,90 @@ void loadBlock() throws IOException {
suf
ChrisHegarty commented on PR #13321:
URL: https://github.com/apache/lucene/pull/13321#issuecomment-2079213000
I went over the Panama code again, and confused myself about the potential
to overflow - there is no issue, but it was not obvious as one has to match the
number of potential values
Pulkitg64 commented on code in PR #13308:
URL: https://github.com/apache/lucene/pull/13308#discussion_r1580903670
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_index/TestBasicBackwardsCompatibility.java:
##
@@ -98,8 +99,14 @@ public class TestBasicBackwardsCompat
benwtrent commented on code in PR #13306:
URL: https://github.com/apache/lucene/pull/13306#discussion_r1581084470
##
lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java:
##
@@ -265,7 +269,6 @@ boolean requiresEviction() {
}
CacheAndCount get(Query key, Index
msokolov commented on issue #9721:
URL: https://github.com/apache/lucene/issues/9721#issuecomment-2079517504
There is another issue associated with this that I only realized when
testing. When there are parent/child queries we need to take care not to split
document blocks across leaves. I'
boicehuang commented on code in PR #13306:
URL: https://github.com/apache/lucene/pull/13306#discussion_r1581231926
##
lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java:
##
@@ -265,7 +269,6 @@ boolean requiresEviction() {
}
CacheAndCount get(Query key, Inde
benwtrent commented on PR #13321:
URL: https://github.com/apache/lucene/pull/13321#issuecomment-2079695750
OK, I ran on Google's ARM machine (`Tau T2A machine series`) to make sure
the ARM performance improvements still exist for int4 (and it wasn't some silly
macos thing):
```
Be
uschindler commented on code in PR #13321:
URL: https://github.com/apache/lucene/pull/13321#discussion_r1581305081
##
lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##
@@ -390,22 +391,139 @@ private int dotProductBody128(byte[] a, b
benwtrent commented on code in PR #13306:
URL: https://github.com/apache/lucene/pull/13306#discussion_r1581481128
##
lucene/core/src/java/org/apache/lucene/search/LRUQueryCache.java:
##
@@ -265,7 +269,6 @@ boolean requiresEviction() {
}
CacheAndCount get(Query key, Index
benwtrent commented on code in PR #13321:
URL: https://github.com/apache/lucene/pull/13321#discussion_r1581482527
##
lucene/core/src/java21/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##
@@ -390,22 +391,139 @@ private int dotProductBody128(byte[] a, by
dsmiley commented on PR #12131:
URL: https://github.com/apache/lucene/pull/12131#issuecomment-2080324742
IMO the complexity inherent (admittedly isn't a lot) in generating
gradle.properties doesn't seem worth the pickiness of the preferences that some
of us apparently have which brought it
dweiss commented on PR #12131:
URL: https://github.com/apache/lucene/pull/12131#issuecomment-2080376757
if your file is in git, adding it to .gitignore doesn't make local changes
ignorable - it's still versioned and git status would show it as modified.
I have not found a way to over
12 matches
Mail list logo
