timgrein opened a new pull request, #13160:
URL: https://github.com/apache/lucene/pull/13160
### Description
`TestDocumentsImpl` uses the `DocumentsTestBase`, which uses the
`RandomIndexWriter` internally for setting up documents to test on.
`addDocument` inside `RandomIndexWriter` c
easyice commented on issue #13116:
URL: https://github.com/apache/lucene/issues/13116#issuecomment-1980472107
In `BKDWriter`, it seems we not pass a class that implements `Runnable` into
the `Thread` framework, it just call `run` method directly, so maybe we can
consider introducing `Check
mikemccand merged PR #13160:
URL: https://github.com/apache/lucene/pull/13160
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
mikemccand closed issue #13130: Reproducible test failure in
TestDocumentsImpl.testFirstTermDoc
URL: https://github.com/apache/lucene/issues/13130
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mikemccand commented on code in PR #13072:
URL: https://github.com/apache/lucene/pull/13072#discussion_r1514268562
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/IntersectTermsEnum.java:
##
@@ -534,6 +555,9 @@ private BytesRef _next() throws IOException {
dweiss commented on issue #13116:
URL: https://github.com/apache/lucene/issues/13116#issuecomment-1980731011
I am not familiar with this code but there are many options to choose from.
A Callable (this throws an Exception), Lucene's IOConsumer, adding
an IORunnable similar to IOConsumer, IO
uschindler opened a new issue, #13161:
URL: https://github.com/apache/lucene/issues/13161
### Description
See https://issues.apache.org/jira/browse/LCN4C-9:
> Apache Lucene CI is disabled for s390x recently on 29th Feb. Couldn't
find any specific reasons why it's disabled.
uschindler commented on issue #13161:
URL: https://github.com/apache/lucene/issues/13161#issuecomment-1980763282
We need Java 21 now, which may not be installed on that machine, so I
disabled it while switching Jenkins jobs- I can quickly fix thus. If you tell
me which Java 21 setup we can
uschindler commented on issue #13161:
URL: https://github.com/apache/lucene/issues/13161#issuecomment-1980764142
Quick feedback: Yes it does not work with Java 21:
```
[Lucene-Check-main (s390x big endian)] $
"/home/jenkins/jenkins-home/712657a4/workspace/Lucene/Lucene-Check-main (
uschindler commented on issue #13161:
URL: https://github.com/apache/lucene/issues/13161#issuecomment-1980774720
CC @Nayana-ibm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
easyice commented on issue #13116:
URL: https://github.com/apache/lucene/issues/13116#issuecomment-1980791102
This is also a good idea! If we use `CheckedRunnable`, we also need to
narrow the type of exceptions thrown to `IOException` only. like:
```diff
- Runnable finalizer = writ
bugmakerr opened a new pull request, #13162:
URL: https://github.com/apache/lucene/pull/13162
### Description
`LeafReader#getXXXVectorValues` may return null value.
**Reproduction**:
```
public class TestKnnByteVectorQuery extends BaseKnnVectorQueryTestCase {
public v
timgrein opened a new pull request, #13163:
URL: https://github.com/apache/lucene/pull/13163
### Description
If you index over 100 documents with the demo application without providing
a KnnVector dictionary you'll run always into this [code
path](https://github.com/apache/lucene/blo
mikemccand commented on code in PR #13149:
URL: https://github.com/apache/lucene/pull/13149#discussion_r1514835629
##
lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java:
##
@@ -36,6 +36,66 @@ final class DocIdsWriter {
private final int[] scratch;
+ privat
gautamworah96 commented on code in PR #13149:
URL: https://github.com/apache/lucene/pull/13149#discussion_r1514939090
##
lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java:
##
@@ -318,9 +378,8 @@ private static void readLegacyDeltaVInts(IndexInput in, int
count,
rmuir commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1981661355
Had to look given the PR title! This doesn't seem so bad?
One benefit of limiting the permission: tests can prevent any more uses from
slipping in (including third party dependencies
rmuir commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1981675442
Another possible improvement as a followup, I can try to find time to look
in, i'm not sure replicator-tests.policy needs to exist anymore. A lot of the
permissions there are outdated sinc
uschindler commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515078703
##
gradle/testing/randomization/policies/replicator-tests.policy:
##
@@ -92,3 +90,14 @@ grant {
// Allow reading from classpath JARs (resources).
permission j
rmuir commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1981725768
I tried it out, i don't want to conflict with your changes here, but if we
add this to main policy:
```
--- a/gradle/testing/randomization/policies/tests.policy
+++ b/gradle/testin
vletard opened a new pull request, #13165:
URL: https://github.com/apache/lucene/pull/13165
### Description
This pull request is a follow up to #12938. I took on the task of complying
with @romseygeek's comment on behalf of [Lexum](https://lexum.com/en/).
I also rebased to the late
dweiss commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515191064
##
gradle/testing/randomization/policies/replicator-tests.policy:
##
@@ -92,3 +90,14 @@ grant {
// Allow reading from classpath JARs (resources).
permission java.
dweiss commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1981843561
Please feel free to commit to this branch, Robert - no problem at all. I
also noticed some of the stuff in policy files is outdated or should be
reviewed - like these properties:
```
dweiss commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515197508
##
gradle/testing/randomization.gradle:
##
@@ -119,6 +119,18 @@ allprojects {
// Resolve test option values after all evaluation is complete.
allprojects {
plugins
rmuir commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1981881836
OK I pushed a commit removing that replicator policy file... to ease our
burden...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
uschindler commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515271087
##
gradle/testing/randomization.gradle:
##
@@ -189,6 +201,14 @@ allprojects {
systemProperty 'gradle.lib.dir',
Paths.get(project.class.location.toURI())
uschindler commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515272998
##
gradle/testing/randomization/policies/replicator-tests.policy:
##
@@ -92,3 +90,14 @@ grant {
// Allow reading from classpath JARs (resources).
permission j
uschindler commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515273890
##
gradle/testing/randomization.gradle:
##
@@ -189,6 +201,14 @@ allprojects {
systemProperty 'gradle.lib.dir',
Paths.get(project.class.location.toURI())
rmuir commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1982028793
ok, sorry for the heavy committing, if one fails lets just revert it, but I
tried to do some cleanup here.
--
This is an automated message from the Apache Git Service.
To respond to the
uschindler commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515282141
##
gradle/testing/randomization.gradle:
##
@@ -119,6 +119,18 @@ allprojects {
// Resolve test option values after all evaluation is complete.
allprojects {
plu
github-actions[bot] commented on PR #13126:
URL: https://github.com/apache/lucene/pull/13126#issuecomment-1982084938
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
rmuir commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1982310705
@uschindler was confused how the crashing tests still work. I debugged just
now and ensured they are actually `halt()`ing the JVM.
The only reason it works is because the crashing te
rmuir commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1982323097
To better improve the crushing tests, instead of the child process killing
itself with unsafe/halt, we can have the parent kill it with
Process.destroyForcibly() and such.
This is e
dweiss commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515605916
##
gradle/testing/randomization.gradle:
##
@@ -189,6 +201,14 @@ allprojects {
systemProperty 'gradle.lib.dir',
Paths.get(project.class.location.toURI()).par
dweiss commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515607191
##
gradle/testing/randomization.gradle:
##
@@ -119,6 +119,18 @@ allprojects {
// Resolve test option values after all evaluation is complete.
allprojects {
plugins
dweiss commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1982546425
Thanks for the follow-ups, @rmuir! It's a great idea to kill the subprocess
from the outside - I'll take a look at that (but not until later, I'm busy
throughout the day).
--
This is a
antonha commented on code in PR #13149:
URL: https://github.com/apache/lucene/pull/13149#discussion_r1515631535
##
lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java:
##
@@ -36,6 +36,66 @@ final class DocIdsWriter {
private final int[] scratch;
+ private f
antonha commented on code in PR #13149:
URL: https://github.com/apache/lucene/pull/13149#discussion_r1515633284
##
lucene/core/src/java/org/apache/lucene/util/bkd/DocIdsWriter.java:
##
@@ -318,9 +378,8 @@ private static void readLegacyDeltaVInts(IndexInput in, int
count, Inters
dweiss commented on PR #13164:
URL: https://github.com/apache/lucene/pull/13164#issuecomment-1982740984
Ok, it wasn't too difficult - I've removed the halt() call and I think it
works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
38 matches
Mail list logo
