dweiss commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515197508
##########
gradle/testing/randomization.gradle:
##########
@@ -119,6 +119,18 @@ allprojects {
// Resolve test option values after all evaluation is complete.
allprojects {
plugins.withType(JavaPlugin) {
+ configurations {
+ secManagerExclusions
+ }
+ dependencies {
+ secManagerExclusions (
"com.carrotsearch.randomizedtesting:randomizedtesting-runner", {
+ exclude group: "junit"
+ })
+ secManagerExclusions ( "junit:junit", {
+ exclude group: "org.hamcrest"
+ })
+ }
+
Review Comment:
A short explanation why this block is here at all - it's simpler to just use
another configuration to pin the location of those dependencies than extract
them from actual test class's classpath arguments (we use modular path
extensions, etc.).
The problem is that these locations can be resolved only after the
configuration is done (gradle's constraint) and at the same time systemProperty
doesn't allow lazy providers so we need to push this into
SecurityArgumentProvider.
I think this could (and should) be simpler but at the moment it's the
simplest what I could come up with.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
