uschindler commented on code in PR #13164:
URL: https://github.com/apache/lucene/pull/13164#discussion_r1515282141
##########
gradle/testing/randomization.gradle:
##########
@@ -119,6 +119,18 @@ allprojects {
// Resolve test option values after all evaluation is complete.
allprojects {
plugins.withType(JavaPlugin) {
+ configurations {
+ secManagerExclusions
+ }
+ dependencies {
+ secManagerExclusions (
"com.carrotsearch.randomizedtesting:randomizedtesting-runner", {
+ exclude group: "junit"
+ })
+ secManagerExclusions ( "junit:junit", {
+ exclude group: "org.hamcrest"
+ })
+ }
+
Review Comment:
Do we need the extra config at all. As we parse through the dependencies
below like `return configurations.secManagerExclusions.resolve().find {
it.name.startsWith("randomizedtesting-runner-") }.absolutePath`, why not use
the test configuration from beginning?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
