uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970680398
I have a branch already with the MRJAR cleanup and ByteBufferIndexInput
removal. I also found a bug in 9.x in the NRTSuggester which wasn't aber to
detect off-heap correctly (it just
stefanvodita commented on code in PR #13017:
URL: https://github.com/apache/lucene/pull/13017#discussion_r1507272812
##
lucene/core/src/java/org/apache/lucene/index/ReadersAndUpdates.java:
##
@@ -782,13 +784,17 @@ synchronized MergePolicy.MergeReader
getReaderForMerge(IOContext
dweiss commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970754253
I allowed myself to merge the main branch and update JVM list in
run-nightly-smoketester.yml.
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
easyice closed pull request #13144: Fix test failure in
TestIndexWriterOnDiskFull.testAddIndexOnDiskFull
URL: https://github.com/apache/lucene/pull/13144
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
uschindler merged PR #13145:
URL: https://github.com/apache/lucene/pull/13145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on issue #9707:
URL: https://github.com/apache/lucene/issues/9707#issuecomment-1970881733
I will close this issue as the `ByteBufferIndexInput` implementation will be
removed in Lucene 10 and was deprecated in 9.x (see #13145). So the available
implementation (`ByteBuff
uschindler closed issue #9707: Replace ByteBuffersIndexInput with
ByteBufferIndexInput (replace and rename) [LUCENE-8661]
URL: https://github.com/apache/lucene/issues/9707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
uschindler opened a new pull request, #13145:
URL: https://github.com/apache/lucene/pull/13145
This is preparation for Lucene 10:
- `ByteBufferIndexInput` was made public for unknown reason (it should have
been private). This officially deprecates the class as it will be removed in
Lucen
uschindler closed pull request #12753: Bump minimum required Java version to 21
URL: https://github.com/apache/lucene/pull/12753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970919007
merged this as 8f17f23acf5c54baaea1361315d23f986f13c0f0
Closing, the DIFF view in this PR is now broken, sorry. No idea how to tell
github to use the original branch.
--
Thi
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970904960
Sorry, I f*cked up the whole branch and this PR because i pushed the wrong
branch to main.
I will just merge it manually and close the PR. Sorry for this. You should
not work w
uschindler opened a new pull request, #13146:
URL: https://github.com/apache/lucene/pull/13146
This PR updates the MR-JAR parts to only have implementations of Java 21.
This PR does not remove the sourceSets for Java 21, although this is also
our base version:
- When compiling vect
rmuir commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970952621
> Closing, the DIFF view in this PR is now broken, sorry. No idea how to
tell github to use the original branch.
This is why I never rebase/force push, and only use merge :)
uschindler commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1970981602
Nah it wasn't because of rebasing or anything like that. I just started a
new branch but forget to switch to it. I then merged Chris' changes in.
I corrected that later, but lef
dweiss commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1971009568
I think you could recover by reverting the wrong merge commit(s), then reset
Chris's branch to the state you want. It's all a graph of states and labels -
you can restore anything you wan
rmuir commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1971039258
I'm just picking fun, there's an old joke about Uwe "merging in
microseconds" with TortoiseSVN...
--
This is an automated message from the Apache Git Service.
To respond to the message,
uschindler commented on PR #13146:
URL: https://github.com/apache/lucene/pull/13146#issuecomment-1971259591
Because this also updated ASM to correct versions, I changed the
JavascriptCompiler to use Java 21 class file format.
--
This is an automated message from the Apache Git Service.
To
dweiss commented on PR #12753:
URL: https://github.com/apache/lucene/pull/12753#issuecomment-1971275304
> Uwe "merging in microseconds" with TortoiseSVN...
Not surprised. If it can be done at all, Uwe is probably capable of it.
--
This is an automated message from the Apache Git Ser
benwtrent commented on PR #13143:
URL: https://github.com/apache/lucene/pull/13143#issuecomment-1971336368
@mccullocht How does this work against segments that were created before
9.9? I know the new reader will support this. But my concern is the SPI loading
Lucene95HNSWReader and that cod
uschindler commented on PR #13146:
URL: https://github.com/apache/lucene/pull/13146#issuecomment-1971597031
Hi,
I will make a separate PR for this: At moment the Java 21 separate sourceSet
is a MRJAR version section. At the moment we would not need a MR-JAR, as we can
merge the classes t
uschindler commented on code in PR #13146:
URL: https://github.com/apache/lucene/pull/13146#discussion_r1507930276
##
gradle/testing/randomization/policies/tests.policy:
##
@@ -50,9 +50,6 @@ grant {
permission java.lang.RuntimePermission "getStackTrace";
// needed for mock
rmuir commented on code in PR #13146:
URL: https://github.com/apache/lucene/pull/13146#discussion_r1507949364
##
lucene/core/src/test/org/apache/lucene/store/TestMMapDirectory.java:
##
@@ -36,30 +34,7 @@ protected Directory getDirectory(Path path) throws
IOException {
retu
mccullocht commented on PR #13143:
URL: https://github.com/apache/lucene/pull/13143#issuecomment-1971644555
@benwtrent Segments before 9.9 would perform a graph search. In
9c3679bf14b0d75cd58e1fda3ca4b8a76aa033b9 I back ported your change from #12806
to 9.1, 9.2, 9.4, and 9.5 since it wasn'
rmuir commented on code in PR #13146:
URL: https://github.com/apache/lucene/pull/13146#discussion_r1507968465
##
lucene/core/src/java/org/apache/lucene/store/FSDirectory.java:
##
@@ -157,7 +157,7 @@ public static FSDirectory open(Path path) throws
IOException {
/** Just li
uschindler commented on code in PR #13146:
URL: https://github.com/apache/lucene/pull/13146#discussion_r1507994376
##
lucene/core/src/java/org/apache/lucene/store/FSDirectory.java:
##
@@ -157,7 +157,7 @@ public static FSDirectory open(Path path) throws
IOException {
/** Ju
uschindler commented on code in PR #13146:
URL: https://github.com/apache/lucene/pull/13146#discussion_r1508002837
##
lucene/core/src/java/org/apache/lucene/store/FSDirectory.java:
##
@@ -157,7 +157,7 @@ public static FSDirectory open(Path path) throws
IOException {
/** Ju
uschindler merged PR #13146:
URL: https://github.com/apache/lucene/pull/13146
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler opened a new pull request, #13148:
URL: https://github.com/apache/lucene/pull/13148
This is a followup after:
https://github.com/apache/lucene/pull/13146#issuecomment-1971597031
This places the compilation unit for Java 21 MRJAR classes in the main
section of JAR file. As
msokolov commented on issue #13147:
URL: https://github.com/apache/lucene/issues/13147#issuecomment-1971797658
One question I have is how to indicate the dense encoding of a block. I see
our blocks start with a single byte that indicates number of packed bits per
doc, 0 means the block is t
dweiss commented on PR #13148:
URL: https://github.com/apache/lucene/pull/13148#issuecomment-1971826752
Right. A bit of puzzling magic - I'm sure people will wonder what happens
here but LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message,
uschindler commented on PR #13148:
URL: https://github.com/apache/lucene/pull/13148#issuecomment-1971895904
The main reason why I like to do this it to make the har file more
compatible with "Maven Shade plugin lovers", e.g., #12968.
The change makes at least mmap usable without corre
uschindler commented on PR #13148:
URL: https://github.com/apache/lucene/pull/13148#issuecomment-1972009022
> Right. A bit of puzzling magic - I'm sure people will wonder what happens
here but LGTM.
I added a comment.
--
This is an automated message from the Apache Git Service.
To
uschindler merged PR #13148:
URL: https://github.com/apache/lucene/pull/13148
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
github-actions[bot] commented on PR #13109:
URL: https://github.com/apache/lucene/pull/13109#issuecomment-1972198347
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
github-actions[bot] commented on PR #12547:
URL: https://github.com/apache/lucene/pull/12547#issuecomment-1972199136
This PR has not had activity in the past 2 weeks, labeling it as stale. If
the PR is waiting for review, notify the d...@lucene.apache.org list. Thank you
for your contributi
uschindler commented on PR #13146:
URL: https://github.com/apache/lucene/pull/13146#issuecomment-1972209088
There was a problem with the test runner permission: It looks like Gradle's
test runner requires to call setAccessible to make the tests working correctly.
Without the permission it c
rmuir commented on PR #13146:
URL: https://github.com/apache/lucene/pull/13146#issuecomment-1972278485
I'm not sure how you debugged that!
I tried to debug what gradle is doing with this tests counter (hey, a
stacktrace of the offending setAccessible would be nice), but I think @dweis
dweiss commented on PR #13146:
URL: https://github.com/apache/lucene/pull/13146#issuecomment-1972569566
It's this issue -
https://github.com/gradle/gradle/issues/11609
they closed the issue but it's still not working as expected.
--
This is an automated message from the Apache Gi
38 matches
Mail list logo
