[GitHub] [lucene] benwtrent commented on a diff in pull request #12314: Multi-value support for KnnVectorField

benwtrent commented on code in PR #12314: URL: https://github.com/apache/lucene/pull/12314#discussion_r1243611229 ## lucene/core/src/java/org/apache/lucene/search/VectorScorer.java: ## @@ -85,6 +96,26 @@ public boolean advanceExact(int doc) throws IOException { return vec

[GitHub] [lucene] benwtrent commented on a diff in pull request #12314: Multi-value support for KnnVectorField

benwtrent commented on code in PR #12314: URL: https://github.com/apache/lucene/pull/12314#discussion_r1243631127 ## lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java: ## @@ -822,40 +836,37 @@ private void writeMeta( * Writes the byte vect

[GitHub] [lucene] alessandrobenedetti commented on a diff in pull request #12314: Multi-value support for KnnVectorField

alessandrobenedetti commented on code in PR #12314: URL: https://github.com/apache/lucene/pull/12314#discussion_r1243704603 ## lucene/core/src/java/org/apache/lucene/search/VectorScorer.java: ## @@ -85,6 +96,26 @@ public boolean advanceExact(int doc) throws IOException {

[GitHub] [lucene] dreamer-89 commented on issue #12391: Support writes with previous major lucene versions

dreamer-89 commented on issue #12391: URL: https://github.com/apache/lucene/issues/12391#issuecomment-1609680281 > I'm confused as to why the solution described won't work with segment replication. As I understand it what that solution describes would be some writer nodes writing segments w

[GitHub] [lucene] sgup432 commented on a diff in pull request #12383: Assign a dummy simScorer in TermsWeight if score is not needed

sgup432 commented on code in PR #12383: URL: https://github.com/apache/lucene/pull/12383#discussion_r1244104004 ## lucene/queries/src/test/org/apache/lucene/queries/function/TestFunctionScoreQuery.java: ## @@ -322,6 +329,19 @@ private void assertInnerScoreMode( ScoreMode

[GitHub] [lucene] mikemccand commented on issue #11507: Increase the number of dims for KNN vectors to 2048 [LUCENE-10471]

mikemccand commented on issue #11507: URL: https://github.com/apache/lucene/issues/11507#issuecomment-1609952036 > We run a benchmarking test, and indexing a dataset of vectors of 1536 dims was slightly faster than indexing of 1024 dims. This gives us enough confidence to extend max dims to

[GitHub] [lucene] rmuir commented on issue #12399: Would SIMD powered sort (on top of Panama) be worth it?

rmuir commented on issue #12399: URL: https://github.com/apache/lucene/issues/12399#issuecomment-1610090785 maybe it would be best to try to make more use out of Arrays.sort given that openjdk is doing this kind of optimization, e.g. https://bugs.openjdk.org/browse/JDK-8309130 curren

[GitHub] [lucene] sgup432 commented on a diff in pull request #12383: Assign a dummy simScorer in TermsWeight if score is not needed

sgup432 commented on code in PR #12383: URL: https://github.com/apache/lucene/pull/12383#discussion_r1244286188 ## lucene/core/src/java/org/apache/lucene/search/TermQuery.java: ## @@ -72,7 +72,16 @@ public TermWeight( if (termStats == null) { this.simScorer = nul

[GitHub] [lucene] sgup432 commented on a diff in pull request #12383: Assign a dummy simScorer in TermsWeight if score is not needed

sgup432 commented on code in PR #12383: URL: https://github.com/apache/lucene/pull/12383#discussion_r1244295952 ## lucene/queries/src/test/org/apache/lucene/queries/function/TestFunctionScoreQuery.java: ## @@ -322,6 +329,19 @@ private void assertInnerScoreMode( ScoreMode

[GitHub] [lucene] sgup432 commented on a diff in pull request #12383: Assign a dummy simScorer in TermsWeight if score is not needed

sgup432 commented on code in PR #12383: URL: https://github.com/apache/lucene/pull/12383#discussion_r1244104004 ## lucene/queries/src/test/org/apache/lucene/queries/function/TestFunctionScoreQuery.java: ## @@ -322,6 +329,19 @@ private void assertInnerScoreMode( ScoreMode

[GitHub] [lucene] uschindler commented on issue #11507: Increase the number of dims for KNN vectors to 2048 [LUCENE-10471]

uschindler commented on issue #11507: URL: https://github.com/apache/lucene/issues/11507#issuecomment-1610151037 Interestingly it was only an Apple M1. This one only has 128 bits vector size and only 2 PU. So I would like to also see the difference on a real cool AVX512 machine with 4 PUs.

[GitHub] [lucene] alessandrobenedetti commented on a diff in pull request #12314: Multi-value support for KnnVectorField

alessandrobenedetti commented on code in PR #12314: URL: https://github.com/apache/lucene/pull/12314#discussion_r1244453767 ## lucene/core/src/java/org/apache/lucene/codecs/lucene95/Lucene95HnswVectorsWriter.java: ## @@ -822,40 +836,37 @@ private void writeMeta( * Writes the

[GitHub] [lucene] jpountz opened a new pull request, #12400: Fix MaxScoreBulkScorer#score's return value.

jpountz opened a new pull request, #12400: URL: https://github.com/apache/lucene/pull/12400 `AssertingBulkScorer` asserts that the return value of `BulkScorer#score` may not be in `[maxDoc, NO_MORE_DOCS)`. While this is not part of the contract of `BulkScorer#score`, a reasonable implementa

[GitHub] [lucene] zhaih commented on a diff in pull request #12380: Add a post-collection hook to LeafCollector.

zhaih commented on code in PR #12380: URL: https://github.com/apache/lucene/pull/12380#discussion_r1244672724 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -749,6 +749,9 @@ protected void search(List leaves, Weight weight, Collector c par

[GitHub] [lucene] jpountz commented on a diff in pull request #12380: Add a post-collection hook to LeafCollector.

jpountz commented on code in PR #12380: URL: https://github.com/apache/lucene/pull/12380#discussion_r1244699937 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -749,6 +749,9 @@ protected void search(List leaves, Weight weight, Collector c p

[GitHub] [lucene] jpountz commented on a diff in pull request #12380: Add a post-collection hook to LeafCollector.

jpountz commented on code in PR #12380: URL: https://github.com/apache/lucene/pull/12380#discussion_r1244700985 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -749,6 +749,9 @@ protected void search(List leaves, Weight weight, Collector c p

[GitHub] [lucene] jpountz commented on a diff in pull request #12383: Assign a dummy simScorer in TermsWeight if score is not needed

jpountz commented on code in PR #12383: URL: https://github.com/apache/lucene/pull/12383#discussion_r1244709649 ## lucene/queries/src/test/org/apache/lucene/queries/function/TestFunctionScoreQuery.java: ## @@ -322,6 +329,19 @@ private void assertInnerScoreMode( ScoreMode

[GitHub] [lucene] jpountz commented on a diff in pull request #12383: Assign a dummy simScorer in TermsWeight if score is not needed

jpountz commented on code in PR #12383: URL: https://github.com/apache/lucene/pull/12383#discussion_r1244710448 ## lucene/core/src/java/org/apache/lucene/search/TermQuery.java: ## @@ -72,7 +72,16 @@ public TermWeight( if (termStats == null) { this.simScorer = nul

[GitHub] [lucene] iverase commented on a diff in pull request #12380: Add a post-collection hook to LeafCollector.

iverase commented on code in PR #12380: URL: https://github.com/apache/lucene/pull/12380#discussion_r1244728353 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -749,6 +749,9 @@ protected void search(List leaves, Weight weight, Collector c p

[GitHub] [lucene] iverase commented on a diff in pull request #12380: Add a post-collection hook to LeafCollector.

iverase commented on code in PR #12380: URL: https://github.com/apache/lucene/pull/12380#discussion_r1244728353 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -749,6 +749,9 @@ protected void search(List leaves, Weight weight, Collector c p