jpountz commented on code in PR #12380: URL: https://github.com/apache/lucene/pull/12380#discussion_r1244700985
########## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ########## @@ -749,6 +749,9 @@ protected void search(List<LeafReaderContext> leaves, Weight weight, Collector c partialResult = true; } } + // Note: this is called if collection ran successfully, including the above special cases of Review Comment: I added `CollectionTerminatedException` to the javadocs but did not add the timeout exception since it's more an implementation detail of how timeout support works in `IndexSearcher`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org