jpountz commented on code in PR #12383:
URL: https://github.com/apache/lucene/pull/12383#discussion_r1244709649
##########
lucene/queries/src/test/org/apache/lucene/queries/function/TestFunctionScoreQuery.java:
##########
@@ -322,6 +329,19 @@ private void assertInnerScoreMode(
ScoreMode expectedScoreMode, ScoreMode inputScoreMode,
DoubleValuesSource valueSource)
throws IOException {
final AtomicReference<ScoreMode> scoreModeInWeight = new
AtomicReference<ScoreMode>();
+ final AtomicBoolean scorerCalled = new AtomicBoolean();
Review Comment:
Yes, please move these tests to `TestTermQuery`. `TestFunctionScoreQuery` is
in a different module, it would be awkward that functionality that lives in
`lucene/core` only gets tested when running tests in `lucene/queries`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
