donnerpeter merged PR #12323:
URL: https://github.com/apache/lucene/pull/12323
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene
gf2121 commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1212892895
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -550,32 +552,41 @@ boolean advanceWithinBlock(IndexedDISI disi, int target)
throws IO
gf2121 commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1212899948
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -418,6 +418,7 @@ public static RandomAccessInput createJumpTable(
// SPARSE varia
gf2121 commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1212903300
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -495,6 +496,7 @@ private void readBlockHeader() throws IOException {
if (numValue
gf2121 commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1212903300
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -495,6 +496,7 @@ private void readBlockHeader() throws IOException {
if (numValue
JarvisCraft commented on code in PR #12290:
URL: https://github.com/apache/lucene/pull/12290#discussion_r1212913125
##
lucene/core/src/java/org/apache/lucene/store/ByteBufferGuard.java:
##
@@ -65,14 +62,8 @@ public ByteBufferGuard(String resourceDescription,
BufferCleaner clean
JarvisCraft commented on PR #12290:
URL: https://github.com/apache/lucene/pull/12290#issuecomment-1571747521
> Please also add a CHANGES.txt entry in 9.7 section.
All done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
JarvisCraft opened a new pull request, #12343:
URL: https://github.com/apache/lucene/pull/12343
### Description
Currently constructors of `Term` require the internal `BytesRef` to be
unmodifiable from the outside
and thus perform defensive copying in order to uphold this invariant.
uschindler commented on PR #12341:
URL: https://github.com/apache/lucene/pull/12341#issuecomment-1571878324
To me this looks fine, although I wonder why we needed a new `Node`
implementation, because `deleteDocuments(Query)` was already using a Query to
delete. Or are those `Node` instances
uschindler commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1571884556
There's no code using this at moment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
uschindler merged PR #12341:
URL: https://github.com/apache/lucene/pull/12341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler opened a new pull request, #12344:
URL: https://github.com/apache/lucene/pull/12344
Reverts apache/lucene#12341
Sorry merged wrong PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
uschindler merged PR #12344:
URL: https://github.com/apache/lucene/pull/12344
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on PR #12341:
URL: https://github.com/apache/lucene/pull/12341#issuecomment-1571886514
Sorry I pressed merge on wrong PR, so I reverted this.
Can you reopen this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
uschindler merged PR #12290:
URL: https://github.com/apache/lucene/pull/12290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
uschindler commented on PR #12290:
URL: https://github.com/apache/lucene/pull/12290#issuecomment-1571897316
Applied and cherry-picked on 9.x branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
uschindler commented on PR #12341:
URL: https://github.com/apache/lucene/pull/12341#issuecomment-1571899485
Of course you can also revert the revert, if that's applicable.
The change looks fine to me.
--
This is an automated message from the Apache Git Service.
To respond to the mes
gf2121 commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1212903300
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -495,6 +496,7 @@ private void readBlockHeader() throws IOException {
if (numValue
mikemccand commented on code in PR #12341:
URL: https://github.com/apache/lucene/pull/12341#discussion_r1213034359
##
lucene/CHANGES.txt:
##
@@ -130,6 +130,9 @@ API Changes
* GITHUB#12268: Add BitSet.clear() without parameters for clearing the entire
set
(Jonathan Ellis)
JarvisCraft commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572161125
> There's no code using this at moment?
What exactly? If you mean the new constructor, no, because the PR is more
useful for foreign callers.
--
This is an automated message
rmuir commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572183658
I think look at how QueryBuilder does this:
```
new Term(field, termAtt.getBytesRef())
```
I don't see any benefit of adding yet another way to do it.
--
This is a
JarvisCraft commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572190112
> I think look at how QueryBuilder does this:
>
> ```
> new Term(field, termAtt.getBytesRef())
> ```
>
> I don't see any benefit of adding yet another way to do it.
rmuir commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572191466
Use `TermAttribute` to do this. the backing `CharTermAttributeImpl`
implements it also.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
rmuir commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572195862
by the way, doing it this way with TermAttribute works with *both* character
(CharTermAttribute) and binary (BinaryTermAttribute) terms.
If we add methods as you propose, it means a
rmuir commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572199241
https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/util/QueryBuilder.java#L287
--
This is an automated message from the Apache Git Service.
To resp
JarvisCraft commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572199694
> Use `TermAttribute` to do this. the backing `CharTermAttributeImpl`
implements it also.
Not sure if it will work in our scenario, but I will giv eit a try. This
however stil
JarvisCraft commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572206386
What I mean is there already a way to create an ill-formed `Term` using the
existing `BytesRef` API: `new Term("foo", new BytesRef(invalidCharSequence))`
and this PR does not affect
rmuir commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572225302
sorry, i'm against this PR. I suggest reading the javadocs of the
TermToBytesRefAttribute and looking at QueryBuilder.
if the terms are binary (non-unicode) then it is senseless and
JarvisCraft commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572304442
> Tusing termtoattribute as i suggest makes its own internal BytesRef.
there's no waste as the BytesRef you get from TermToBytesRefAttribute is
re-used (look at the source code). Thi
zhaih commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1213482394
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -495,6 +496,7 @@ private void readBlockHeader() throws IOException {
if (numValues
zhaih commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1213482867
##
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##
@@ -418,6 +418,7 @@ public static RandomAccessInput createJumpTable(
// SPARSE variab
dnhatn commented on PR #12326:
URL: https://github.com/apache/lucene/pull/12326#issuecomment-1572574391
@tflobbe Thanks for working on this. I am looking at the PR now. Sorry for
the delay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Deepika0510 opened a new pull request, #12345:
URL: https://github.com/apache/lucene/pull/12345
# Description
IndexSearcher only checks the query timeout in the collection phase for now.
Need to add timeout support in case of other operations that may take time such
as query rewrite,
JarvisCraft commented on PR #12343:
URL: https://github.com/apache/lucene/pull/12343#issuecomment-1572840979
In this case, I will close the PR.
Thanks again for the advice!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
zhaih commented on PR #12341:
URL: https://github.com/apache/lucene/pull/12341#issuecomment-1572941930
> I wonder why we needed a new Node implementation
@uschindler We previously have a `Node` impl as previous
`deleteDocuments` took `(Query...)`. I added that `Node` just to comply
w
zhaih commented on code in PR #12341:
URL: https://github.com/apache/lucene/pull/12341#discussion_r1213792362
##
lucene/core/src/test/org/apache/lucene/index/TestIndexWriter.java:
##
@@ -3476,7 +3476,12 @@ public int numDeletesToMerge(
Document doc = new D
zhaih opened a new pull request, #12346:
URL: https://github.com/apache/lucene/pull/12346
### Description
Please see https://github.com/apache/lucene/pull/12341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
zhaih commented on PR #12341:
URL: https://github.com/apache/lucene/pull/12341#issuecomment-1572949556
For some reason I cannot reopen this one, so I opened a new one #12346
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dnhatn commented on code in PR #12326:
URL: https://github.com/apache/lucene/pull/12326#discussion_r1213908644
##
lucene/core/src/java/org/apache/lucene/index/FieldInfos.java:
##
@@ -708,6 +750,23 @@ FieldInfo add(FieldInfo fi, long dvGen) {
final FieldInfo curFi = fieldI
39 matches
Mail list logo
