gf2121 commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1212899948


##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##########
@@ -418,6 +418,7 @@ public static RandomAccessInput createJumpTable(
 
   // SPARSE variables
   boolean exists;
+  int nextExistDocInBlock = -1;

Review Comment:
   ```
     int block = -1;
     long blockEnd;
     long denseBitmapOffset = -1; // Only used for DENSE blocks
     int nextBlockIndex = -1;
     Method method;
   
     int doc = -1;
     int index = -1;
   
     // SPARSE variables
     boolean exists;
     int nextExistDocInBlock = -1;
   
     // DENSE variables
     long word;
     int wordIndex = -1;
   ```
   There has already been several -1 defined here to mean the uninitialized 
status. And as talked below Integer.MAX_VALUE should be removed. So I prefer to 
keep what it is. What do you think?
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to