gf2121 commented on code in PR #12324:
URL: https://github.com/apache/lucene/pull/12324#discussion_r1212903300
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##########
@@ -495,6 +496,7 @@ private void readBlockHeader() throws IOException {
if (numValues <= MAX_ARRAY_LENGTH) {
method = Method.SPARSE;
blockEnd = slice.getFilePointer() + (numValues << 1);
+ nextExistDocInBlock = -1;
} else if (numValues == 65536) {
Review Comment:
Sorry, I'm not sure i've got your point. Do you mean change to
`nextExistDocInBlock = BLOCK_SIZE;` ?
I think that will make `SPARSE$advanceExact` alwayse return false.
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/IndexedDISI.java:
##########
@@ -495,6 +496,7 @@ private void readBlockHeader() throws IOException {
if (numValues <= MAX_ARRAY_LENGTH) {
method = Method.SPARSE;
blockEnd = slice.getFilePointer() + (numValues << 1);
+ nextExistDocInBlock = -1;
} else if (numValues == 65536) {
Review Comment:
Sorry, I'm not sure i've got your point. Do you mean change to
`nextExistDocInBlock = BLOCK_SIZE;` ?
I think that will make `SPARSE$advanceExact` always return false.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
