dantuzi commented on PR #12169:
URL: https://github.com/apache/lucene/pull/12169#issuecomment-1467824945
@rmuir we spent some time analyzing the code after your comments.
Index Time
At index time the BoostAttribute is ignored as you said but, it looks like
we "waste" 4 bytes to st
mkhludnev commented on PR #12169:
URL: https://github.com/apache/lucene/pull/12169#issuecomment-1467861676
For matter of fact, PositionLengthAttribute is also ignored by indexer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
rmuir commented on PR #12169:
URL: https://github.com/apache/lucene/pull/12169#issuecomment-1467945170
> I'll leave the BoostAttribute discussion for another time as I don't have
access to the code right now, but javaDocs or not, it seems extremely
suspicious to have a public class that sho
rmuir commented on PR #12169:
URL: https://github.com/apache/lucene/pull/12169#issuecomment-1467949618
Here is what the documentation says:
```
/**
* Add this {@link Attribute} to a {@link TermsEnum} returned by {@link
* MultiTermQuery#getTermsEnum(Terms,AttributeSource)} and up
nknize commented on PR #12159:
URL: https://github.com/apache/lucene/pull/12159#issuecomment-1468185780
> Awesome. Thanks all for the review.
>
> The main branch is protected. I cannot merge anything myself. Has to be a
committer, I believe, even after approval.
Done!
--
Thi
nknize merged PR #12159:
URL: https://github.com/apache/lucene/pull/12159
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
benwtrent commented on code in PR #12197:
URL: https://github.com/apache/lucene/pull/12197#discussion_r1135638431
##
lucene/core/src/java/org/apache/lucene/search/Query.java:
##
@@ -77,10 +85,28 @@ public Weight createWeight(IndexSearcher searcher,
ScoreMode scoreMode, float bo
benwtrent commented on code in PR #12197:
URL: https://github.com/apache/lucene/pull/12197#discussion_r1135639238
##
lucene/core/src/java/org/apache/lucene/search/Query.java:
##
@@ -45,6 +46,13 @@
*/
public abstract class Query {
+ static final VirtualMethod oldMethod =
R
dsmiley commented on PR #12169:
URL: https://github.com/apache/lucene/pull/12169#issuecomment-1468429202
@rmuir Why is it important that BoostAttribute's usage be constrained to
only MultiTermQuery?
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
alessandrobenedetti commented on PR #12169:
URL: https://github.com/apache/lucene/pull/12169#issuecomment-1468487080
> > I'll leave the BoostAttribute discussion for another time as I don't
have access to the code right now, but javaDocs or not, it seems extremely
suspicious to have a publi
mdmarshmallow commented on PR #12194:
URL: https://github.com/apache/lucene/pull/12194#issuecomment-1468722127
Sorry for the delayed response, so I saw it in my optimized version of
`BitSet#or` that does use the `peekNextNonMatchingDocID` API. I also found the
bug, it turns out we just were
navneet1v commented on issue #11702:
URL: https://github.com/apache/lucene/issues/11702#issuecomment-1469006135
@rendel so what is the final outcome here? Should we start working on
Multi-Value Support for Binary DocValues?
@nknize
--
This is an automated message from the Apache G
12 matches
Mail list logo
