jpountz commented on PR #12051:
URL: https://github.com/apache/lucene/pull/12051#issuecomment-1368388218
Thanks for catching this. Would it also work if we fixed indexing to
sometimes index other values, e.g. replacing `if (random().nextBoolean()) {`
with `if (i != 3 && random().nextBoolean
jpountz opened a new pull request, #12053:
URL: https://github.com/apache/lucene/pull/12053
Today Lucene allows creating indexed binary fields, e.g. via
`StringField(String, BytesRef, Field.Store)`, but not reusing them: calling
`setBytesValue` on a `StringField` throws.
This commit
jpountz opened a new pull request, #12054:
URL: https://github.com/apache/lucene/pull/12054
`KeywordField` is a combination of `StringField` and
`SortedSetDocValuesField`, similarly to how `LongField` is a combination of
`LongPoint` and `SortedNumericDocValuesField`. This makes it easier fo
jpountz opened a new pull request, #12055:
URL: https://github.com/apache/lucene/pull/12055
Currently multi-term queries with a filter rewrite internally rewrite to a
disjunction if 16 terms or less match the query. Otherwise postings lists of
matching terms are collected into a `DocIdSetBu
jpountz commented on PR #12055:
URL: https://github.com/apache/lucene/pull/12055#issuecomment-1368422269
Here is what luceneutil gives on wikimedium10m:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDevPct diff p-value
jpountz commented on PR #12055:
URL: https://github.com/apache/lucene/pull/12055#issuecomment-1368423502
For the record, the reason why we're seeing a speedup here is because prefix
and wildcard queries produce constant scores, so the query can early terminate
once 1,000 hits have been coll
msokolov merged PR #12047:
URL: https://github.com/apache/lucene/pull/12047
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.ap
twosom commented on PR #12047:
URL: https://github.com/apache/lucene/pull/12047#issuecomment-1368474848
@msokolov
Thanks~!
and Happy New Year!👻
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
msokolov commented on code in PR #12029:
URL: https://github.com/apache/lucene/pull/12029#discussion_r1059769467
##
lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java:
##
@@ -33,6 +33,7 @@
import org.apache.lucene.store.Directory;
import org.apache.lucene.ut
msokolov commented on PR #12048:
URL: https://github.com/apache/lucene/pull/12048#issuecomment-1368477965
Sorry, I don't see this being any better than the current situation; aside
from tests, the parameters are only used in HnswVectorsFormat where they are
currently defined, so I think we
msokolov commented on issue #11354:
URL: https://github.com/apache/lucene/issues/11354#issuecomment-1368479497
HI Jack, thanks for persisting and returning to this. I haven't had a chance
to review the PR yet, just looking at the results here I have a few questions.
First, it looks to me as
rmuir commented on PR #12053:
URL: https://github.com/apache/lucene/pull/12053#issuecomment-1368481511
> I considered an alternative that consisted of failing if calling
`setBytesValue` on a field that is indexed and tokenized
Can we just do this instead?
I think an important p
rmuir commented on PR #12053:
URL: https://github.com/apache/lucene/pull/12053#issuecomment-1368481827
and yeah, you don't have such checks on numeric values, but numeric values
don't have TokenStream tokenization. Being consistent with them makes no sense,
that isn't what this is about.
rmuir commented on PR #12053:
URL: https://github.com/apache/lucene/pull/12053#issuecomment-1368482600
the fact that the tests pass with this change is really upsetting too. we
should at least add checks for the type of luser moments we want to prevent,
e.g. calling setBytesRef on a fucking
zhaih commented on PR #12051:
URL: https://github.com/apache/lucene/pull/12051#issuecomment-1368503412
Yeah it should work unless we later come up with some way to quickly pull
out count in that situation as well.
But I think the assertion here may not be necessary because I see you
rmuir opened a new pull request, #12056:
URL: https://github.com/apache/lucene/pull/12056
I investigated each of the new checks, nothing really interesting except an
incorrect javadoc link (discovered manually) linking to Object.finalize()
--
This is an automated message from the Apache G
rmuir opened a new issue, #12057:
URL: https://github.com/apache/lucene/issues/12057
### Description
I was looking at new error-prone checks in #12056 and one fails on
Object.finalize
Because the method is in the built-in JDK deprecated list (e.g.
https://github.com/policeman-
rmuir commented on issue #12057:
URL: https://github.com/apache/lucene/issues/12057#issuecomment-1368524586
Here's how to reproduce: apply this patch, then run `gradlew check -x test`.
I would expect the build to fail, because we added a deprecated finalizer.
Maybe forbidden doesn't fail be
rmuir commented on issue #12057:
URL: https://github.com/apache/lucene/issues/12057#issuecomment-1368527335
Confirmed that's the issue, if i add a `super.finalize()` call to my
finalizer, then forbidden fails. I will edit the issue.
So we may need to use a different tool (javac, ecj)
rmuir commented on issue #12057:
URL: https://github.com/apache/lucene/issues/12057#issuecomment-1368539424
Currently there is no good way with ECJ/javac, unless we fail on all
deprecations, which is very noisy at the moment. We can probably do it better
with ECJ if we enable all their depr
uschindler opened a new pull request, #12058:
URL: https://github.com/apache/lucene/pull/12058
This improves the test, which fails with OpenJ9 VMs, due to the following
problem:
- OpenJ9 returns the HotspotMXBean, but it is empty and has no properties.
So we can't detect compressed point
uschindler commented on PR #12058:
URL: https://github.com/apache/lucene/pull/12058#issuecomment-1368556378
Thanks Robert!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
uschindler merged PR #12058:
URL: https://github.com/apache/lucene/pull/12058
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
rmuir commented on code in PR #12055:
URL: https://github.com/apache/lucene/pull/12055#discussion_r1059804843
##
lucene/core/src/java/org/apache/lucene/search/MultiTermQueryConstantScoreWrapper.java:
##
@@ -183,23 +182,31 @@ private WeightOrDocIdSet rewrite(LeafReaderContext
co
rmuir commented on code in PR #12055:
URL: https://github.com/apache/lucene/pull/12055#discussion_r1059807197
##
lucene/core/src/java/org/apache/lucene/search/MultiTermQueryConstantScoreWrapper.java:
##
@@ -183,23 +182,31 @@ private WeightOrDocIdSet rewrite(LeafReaderContext
co
rmuir commented on code in PR #12055:
URL: https://github.com/apache/lucene/pull/12055#discussion_r1059807649
##
lucene/core/src/java/org/apache/lucene/search/MultiTermQueryConstantScoreWrapper.java:
##
@@ -183,23 +182,31 @@ private WeightOrDocIdSet rewrite(LeafReaderContext
co
uschindler closed issue #8485: TestIndexWriterOnError.testCheckpoint fails on
IBM J9 [LUCENE-7432]
URL: https://github.com/apache/lucene/issues/8485
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
uschindler commented on issue #7580:
URL: https://github.com/apache/lucene/issues/7580#issuecomment-1368575244
This seems fixed now, tets no longer fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
uschindler closed issue #7580: Reproducible fieldcache AIOOBE only on J9
[LUCENE-6522]
URL: https://github.com/apache/lucene/issues/7580
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
uschindler closed issue #7579: org.apache.xerces.util is a protected pkg on IBM
J9 [LUCENE-6521]
URL: https://github.com/apache/lucene/issues/7579
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
uschindler commented on issue #7579:
URL: https://github.com/apache/lucene/issues/7579#issuecomment-1368575466
This is fixed in J9, as it now uses OpenJDK class library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
uschindler closed issue #7575: mockfilesystem tests fail with IBM jdk
[LUCENE-6517]
URL: https://github.com/apache/lucene/issues/7575
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific com
uschindler commented on issue #7575:
URL: https://github.com/apache/lucene/issues/7575#issuecomment-1368575612
This should no longer be an issue, as OpenJ9 uses the OpenJDK class library
now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
uschindler commented on issue #7614:
URL: https://github.com/apache/lucene/issues/7614#issuecomment-1368575794
This is no longer an issue, all tests pass, because OpenJ9 now uses the
OpenJDK class library and no longer Harmony.
--
This is an automated message from the Apache Git Service.
uschindler closed issue #7614: TestQueryTemplateManager always fails on J9
[LUCENE-6556]
URL: https://github.com/apache/lucene/issues/7614
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
uschindler commented on issue #7580:
URL: https://github.com/apache/lucene/issues/7580#issuecomment-1368576005
In addition, Lucene has no fieldcache anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
uschindler closed issue #5001: TestNRTManager hangs with IBM JRE [LUCENE-3928]
URL: https://github.com/apache/lucene/issues/5001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
uschindler commented on issue #5001:
URL: https://github.com/apache/lucene/issues/5001#issuecomment-1368577762
This test now passes with IBM Semeru / OpenJ9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jasirkt commented on issue #11701:
URL: https://github.com/apache/lucene/issues/11701#issuecomment-1368693920
> In which verison did you see this?
9.1.0
Thanks for fixing. It works now!
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
39 matches
Mail list logo
