rmuir commented on issue #12057: URL: https://github.com/apache/lucene/issues/12057#issuecomment-1368539424
Currently there is no good way with ECJ/javac, unless we fail on all deprecations, which is very noisy at the moment. We can probably do it better with ECJ if we enable all their deprecation options, and clean up codebase (e.g. ensure tests calling deprecated stuff are also themselves deprecated) * org.eclipse.jdt.core.compiler.problem.deprecation * org.eclipse.jdt.core.compiler.problem.deprecationInDeprecatedCode * org.eclipse.jdt.core.compiler.problem.deprecationWhenOverridingDeprecatedMethod But looking at the code, that's gonna require quite a bit of work, I just wanted to make some progress here and prevent finalizers from slipping in. Unfortunately the error-prone checker doesn't fail on this case either yet: https://github.com/google/error-prone/pull/3652 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
