zhaih commented on PR #12051: URL: https://github.com/apache/lucene/pull/12051#issuecomment-1368503412
Yeah it should work unless we later come up with some way to quickly pull out count in that situation as well. But I think the assertion here may not be necessary because I see you have already added a specific test testing more comprehensive situations where boolean weights should or should not return -1. The assertion here seems was introduced at the time when the `Weight#count` API was first introduced and should be removed IMO since we have had a non-default impl right now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
