[GitHub] [lucene] jpountz commented on a diff in pull request #11998: Migrate away from per-segment-per-threadlocals on SegmentReader

jpountz commented on code in PR #11998: URL: https://github.com/apache/lucene/pull/11998#discussion_r1043042489 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseStoredFieldsFormatTestCase.java: ## @@ -813,6 +837,7 @@ public void testBulkMergeWithDeletes() thro

[GitHub] [lucene] romseygeek merged pull request #11999: Add support for stored fields to MemoryIndex

romseygeek merged PR #11999: URL: https://github.com/apache/lucene/pull/11999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] jpountz commented on a diff in pull request #11998: Migrate away from per-segment-per-threadlocals on SegmentReader

jpountz commented on code in PR #11998: URL: https://github.com/apache/lucene/pull/11998#discussion_r1043183580 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseStoredFieldsFormatTestCase.java: ## @@ -813,6 +837,7 @@ public void testBulkMergeWithDeletes() thro

[GitHub] [lucene] rmuir commented on a diff in pull request #11998: Migrate away from per-segment-per-threadlocals on SegmentReader

rmuir commented on code in PR #11998: URL: https://github.com/apache/lucene/pull/11998#discussion_r1043343548 ## lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseStoredFieldsFormatTestCase.java: ## @@ -813,6 +837,7 @@ public void testBulkMergeWithDeletes() throws

[GitHub] [lucene] gf2121 commented on pull request #11880: Use ByteArrayComparator to replace Arrays#compareUnsigned in some other places

gf2121 commented on PR #11880: URL: https://github.com/apache/lucene/pull/11880#issuecomment-1342933516 @jpountz Sorry for being late, thank you for the review ! I'll merge this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] gf2121 merged pull request #11880: Use ByteArrayComparator to replace Arrays#compareUnsigned in some other places

gf2121 merged PR #11880: URL: https://github.com/apache/lucene/pull/11880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] gf2121 opened a new pull request, #12001: Use ByteArrayComparator to replace Arrays#compareUnsigned in some other places (Backport 9x)

gf2121 opened a new pull request, #12001: URL: https://github.com/apache/lucene/pull/12001 Backport of https://github.com/apache/lucene/pull/11880 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [lucene] gf2121 merged pull request #12001: Use ByteArrayComparator to replace Arrays#compareUnsigned in some other places (Backport 9x)

gf2121 merged PR #12001: URL: https://github.com/apache/lucene/pull/12001 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] jpountz commented on pull request #11998: Migrate away from per-segment-per-threadlocals on SegmentReader

jpountz commented on PR #11998: URL: https://github.com/apache/lucene/pull/11998#issuecomment-1343043440 I pushed most call sites I think. The main remaining ones are in lucene/highlighter, which require a bit more changes. -- This is an automated message from the Apache Git Service. To r

[GitHub] [lucene] rmuir commented on a diff in pull request #11998: Migrate away from per-segment-per-threadlocals on SegmentReader

rmuir commented on code in PR #11998: URL: https://github.com/apache/lucene/pull/11998#discussion_r1043614087 ## lucene/queries/src/java/org/apache/lucene/queries/mlt/MoreLikeThis.java: ## @@ -268,6 +270,12 @@ public final class MoreLikeThis { /** IndexReader to use */ pri

[GitHub] [lucene] jpountz commented on a diff in pull request #11998: Migrate away from per-segment-per-threadlocals on SegmentReader

jpountz commented on code in PR #11998: URL: https://github.com/apache/lucene/pull/11998#discussion_r1043616431 ## lucene/queries/src/java/org/apache/lucene/queries/mlt/MoreLikeThis.java: ## @@ -268,6 +270,12 @@ public final class MoreLikeThis { /** IndexReader to use */ p

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #11958: GITHUB-11868: Add FilterIndexInput and FilterIndexOutput wrapper classes

mdmarshmallow commented on code in PR #11958: URL: https://github.com/apache/lucene/pull/11958#discussion_r1043767490 ## lucene/core/src/test/org/apache/lucene/index/TestFilterIndexInput.java: ## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #11958: GITHUB-11868: Add FilterIndexInput and FilterIndexOutput wrapper classes

mdmarshmallow commented on code in PR #11958: URL: https://github.com/apache/lucene/pull/11958#discussion_r1043768983 ## lucene/core/src/java/org/apache/lucene/store/FilterIndexInput.java: ## @@ -0,0 +1,89 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene] jmazanec15 opened a new pull request, #12002: Set algorithm params during force merge in KnnGraphTester

jmazanec15 opened a new pull request, #12002: URL: https://github.com/apache/lucene/pull/12002 ### Description Sets index writer config codec for force merge operation in KnnGraphTester. Fixes issue where merged segments are built with different algorithm parameters than segments cre

[GitHub] [lucene] gsmiller opened a new pull request, #12003: Some minor code cleanup in IndexSortSortedNumericDocValuesRangeQuery

gsmiller opened a new pull request, #12003: URL: https://github.com/apache/lucene/pull/12003 * Leverage DISI static factory methods more over custom DISI impl where possible * Assert points field is a single-dim in a couple places * Bound cost estimate by the cost of the doc values fie

[GitHub] [lucene] benwtrent opened a new pull request, #12004: Move byte vector queries into new KnnByteVectorQuery

benwtrent opened a new pull request, #12004: URL: https://github.com/apache/lucene/pull/12004 This is the first commit of a much larger refactor. The overall goal is to separate the concerns of byte vectors and float vectors. Making their usage and APIs clearer for users. This first

[GitHub] [lucene] benwtrent commented on pull request #12004: Move byte vector queries into new KnnByteVectorQuery

benwtrent commented on PR #12004: URL: https://github.com/apache/lucene/pull/12004#issuecomment-1343454137 @rmuir the first of the multiple refactors. I attempted first to do it all in one change, but this proved to be an absolutely huge change (6k+ LOC churn) that spread across many

[GitHub] [lucene-jira-archive] dependabot[bot] opened a new pull request, #149: Bump certifi from 2022.6.15 to 2022.12.7 in /migration

dependabot[bot] opened a new pull request, #149: URL: https://github.com/apache/lucene-jira-archive/pull/149 Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.6.15 to 2022.12.7. Commits https://github.com/certifi/python-certifi/commit/9e9e840925d7b8e76c76fdac