rmuir commented on code in PR #11998:
URL: https://github.com/apache/lucene/pull/11998#discussion_r1043614087
##########
lucene/queries/src/java/org/apache/lucene/queries/mlt/MoreLikeThis.java:
##########
@@ -268,6 +270,12 @@ public final class MoreLikeThis {
/** IndexReader to use */
private final IndexReader ir;
+ /** Stored fields for {@code ir}. */
+ private final StoredFields storedFields;
Review Comment:
hmm, should we do it this way as instance members? `MoreLikeThis` was
thread-safe before... i think. This would now make it unsafe. Maybe we should
just create these in the actual method that wants to pull from storedfields?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
