[GitHub] [lucene] iverase opened a new issue, #11883: Spatial3d: Wrong intersection detected between small polygons

iverase opened a new issue, #11883: URL: https://github.com/apache/lucene/issues/11883 ### Description The following polygon corresponds to the uber h3 boundary cell "8cc373cb54069ff": ``` POLYGON((-64.2102198418716 -39.14233318389477,-64.21016450005413 -39.142267144439614,-64.

[GitHub] [lucene] mikemccand commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

mikemccand commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1293237593 > If we do both at same time, we won't see a difference between old and new Lucene MMAP (on same version). A JDK upgrade may also change other performance numbers. Ack -- I turned

[GitHub] [lucene] LuXugang opened a new pull request, #11884: Simplify the logic of matchAll() in IndexSortSortedNumericDocValuesRangeQuery

LuXugang opened a new pull request, #11884: URL: https://github.com/apache/lucene/pull/11884 Could we do this simplification, make it more readable？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [lucene] uschindler commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

uschindler commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1293275751 > > If we do both at same time, we won't see a difference between old and new Lucene MMAP (on same version). A JDK upgrade may also change other performance numbers. > > Ack -- I t

[GitHub] [lucene] uschindler commented on pull request #912: MR-JAR rewrite of MMapDirectory with JDK-19 preview Panama APIs (>= JDK-19-ea+23)

uschindler commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1293279030 Please do not wonder why "convEndian" is always on top of the call stack: The method is always called, although the endianness fits. It is just a NOOP on x86. -- This is an automated m

[GitHub] [lucene] rmuir commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

rmuir commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1006806308 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: these are separate concerns. the jacocol

[GitHub] [lucene] gsmiller commented on pull request #11884: Simplify the logic of matchAll() in IndexSortSortedNumericDocValuesRangeQuery

gsmiller commented on PR #11884: URL: https://github.com/apache/lucene/pull/11884#issuecomment-1293543997 Looks reasonable to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [lucene] mikemccand commented on issue #11601: Can we "warm" SSDV ordinal maps on index reopen? [LUCENE-10565]

mikemccand commented on issue #11601: URL: https://github.com/apache/lucene/issues/11601#issuecomment-1293639556 +1 to explore using `FacetsConfig` to track which fields should pre-compute ordinal maps during refresh. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [lucene] dweiss commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

dweiss commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007192722 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: If so, fine, but I wouldn't want the ja

[GitHub] [lucene] rmuir commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

rmuir commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007196815 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: agreed, i dont know why `java` is needed

[GitHub] [lucene-solr] risdenk commented on pull request #1931: SOLR-14597 Advanced Query Parser (WIP)

risdenk commented on PR #1931: URL: https://github.com/apache/lucene-solr/pull/1931#issuecomment-1293895656 I think this is being followed up here: https://github.com/apache/solr/pull/128 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [lucene-solr] risdenk closed pull request #1931: SOLR-14597 Advanced Query Parser (WIP)

risdenk closed pull request #1931: SOLR-14597 Advanced Query Parser (WIP) URL: https://github.com/apache/lucene-solr/pull/1931 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [lucene] nknize commented on pull request #11753: Added interface to relate a LatLonShape with another shape represented as Component2D

nknize commented on PR #11753: URL: https://github.com/apache/lucene/pull/11753#issuecomment-1293914786 16days since my review. If there are no concerns in the next 24 hrs I'll merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [lucene] mikemccand merged pull request #11796: GITHUB#11795: Add FilterDirectory to track write amplification factor

mikemccand merged PR #11796: URL: https://github.com/apache/lucene/pull/11796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.

[GitHub] [lucene] mikemccand commented on pull request #11796: GITHUB#11795: Add FilterDirectory to track write amplification factor

mikemccand commented on PR #11796: URL: https://github.com/apache/lucene/pull/11796#issuecomment-1293952235 Thanks @mdmarshmallow! Sorry for the delay merging ... I will backport to 9.x then let's get this in nightly benchmarks :) -- This is an automated message from the Apache Git Servi

[GitHub] [lucene] mikemccand commented on pull request #11796: GITHUB#11795: Add FilterDirectory to track write amplification factor

mikemccand commented on PR #11796: URL: https://github.com/apache/lucene/pull/11796#issuecomment-1294015472 9.x backport done: https://github.com/apache/lucene/commit/373d2e84c13ee67e8e1247338e69b53946b7f726 -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [lucene] dweiss commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

dweiss commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007348123 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: I've removed plugin application and reo

[GitHub] [lucene] dweiss commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

dweiss commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007360936 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: I've no idea why that plugin triggers a

[GitHub] [lucene] zhaih commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

zhaih commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007370858 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: > I've no idea why that plugin triggers

[GitHub] [lucene] zhaih commented on pull request #11882: gradle aggregated coverage console log and html location

zhaih commented on PR #11882: URL: https://github.com/apache/lucene/pull/11882#issuecomment-1294063372 Thanks @dweiss! I was having some hard time understanding the dependencies between plugins so thank you for jumping out and help! I tested the change and it looks good to me. > but it

[GitHub] [lucene] zhaih opened a new issue, #11885: Refactor and generalize file deleter

zhaih opened a new issue, #11885: URL: https://github.com/apache/lucene/issues/11885 ### Description As far as I know there're 2 file deleters inside lucene, one is `IndexFileDeleter` which is package private and only used by `IndexWriter`, another is `ReplicaFileDelter` which is als

[GitHub] [lucene] nknize commented on issue #11702: Multi-Value Support for Binary DocValues [LUCENE-10666]

nknize commented on issue #11702: URL: https://github.com/apache/lucene/issues/11702#issuecomment-1294232828 My muscle memory (and gmail filters) is stuck at jira :) So I missed these. > The use-case here is also not great, talking about a doc having multiple locations Curious

[GitHub] [lucene] rmuir commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

rmuir commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007467241 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: > However, the problem with third party

[GitHub] [lucene] rmuir commented on issue #11885: Refactor and generalize file deleter

rmuir commented on issue #11885: URL: https://github.com/apache/lucene/issues/11885#issuecomment-1294359672 would be cool to see what you have in mind. personally i find the `IndexFileDeleter` terrifying: it does have an appropriately scary name, you can't argue with that! We have to procee

[GitHub] [lucene] dweiss commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

dweiss commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007634326 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: Yeah, I think it's broken somewhere and

[GitHub] [lucene] dweiss commented on a diff in pull request #11882: gradle aggregated coverage console log and html location

dweiss commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007635318 ## lucene/build.gradle: ## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: The 'mustRunAfter' is actually correct

[GitHub] [lucene] dweiss opened a new pull request, #11886: Upgrade to gradle 7.5.1 (excluding launch scripts, which we have customized)

dweiss opened a new pull request, #11886: URL: https://github.com/apache/lucene/pull/11886 Upgrade gradle to 7.5.1. Switch distribution type to 'bin' instead of 'all' (smaller, excludes documentation and examples - these are irrelevant for us and are available online). gradlew launch

[GitHub] [lucene] dweiss opened a new issue, #11887: TestDocumentsWriterStallControl takes over a minute with -Ptests.seed=B83F4990EF501F47

dweiss opened a new issue, #11887: URL: https://github.com/apache/lucene/issues/11887 ### Description ``` gradlew test -p lucene/core --tests *TestDocumentsWriterStallControl* -Ptests.seed=B83F4990EF501F47 ``` I noticed this while running unrelated tests but it does repro

[GitHub] [lucene] dweiss commented on pull request #11886: Upgrade to gradle 7.5.1 (excluding launch scripts, which we have customized)

dweiss commented on PR #11886: URL: https://github.com/apache/lucene/pull/11886#issuecomment-1294538240 I take the liberty of merging this, since it's a trivial change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

[GitHub] [lucene] dweiss merged pull request #11886: Upgrade to gradle 7.5.1 (excluding launch scripts, which we have customized)

dweiss merged PR #11886: URL: https://github.com/apache/lucene/pull/11886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[GitHub] [lucene] dweiss commented on pull request #11856: Fix nanos to millis conversion for tests

dweiss commented on PR #11856: URL: https://github.com/apache/lucene/pull/11856#issuecomment-1294546086 I think this is ready to be merged, sorry for the delay. One thing - could you add an appropriate lucene/CHANGES.txt entry? -- This is an automated message from the Apache Git Service.