dweiss commented on code in PR #11882: URL: https://github.com/apache/lucene/pull/11882#discussion_r1007348123
########## lucene/build.gradle: ########## @@ -15,6 +15,8 @@ * limitations under the License. */ +apply plugin: 'java' Review Comment: I've removed plugin application and reorganized the logic there a bit - coverage shouldn't trigger all test tasks to run (it previously did), it should just finalize any test task that was otherwise invoked. So something like this works: ``` gradlew :lucene:analysis:kuromoji:test -Ptests.coverage=true ``` I think the 'coverage' task is no longer strictly necessary... but I made it depend on the default 'test' task so that this also works: ``` gradlew :lucene:analysis:kuromoji:test -Ptests.coverage=true ``` However, the problem with third party plugins is that they're hard to explain sometimes. I made a top-level coverage task that should just aggregate any other test coverage reports... but it triggers all test tasks to run (including those from hunspell that are not run by default!). I've no idea why this happens, eh. ``` gradlew :lucene:analysis:kuromoji:test :coverage -Ptests.coverage=true ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
