uschindler commented on PR #912: URL: https://github.com/apache/lucene/pull/912#issuecomment-1293275751
> > If we do both at same time, we won't see a difference between old and new Lucene MMAP (on same version). A JDK upgrade may also change other performance numbers. > > Ack -- I turned on just the JDK 19 upgrade last night! > > `PKLookup` looks [a bit happy](https://home.apache.org/~mikemccand/lucenebench/PKLookup.html) about the upgrade, but otherwise I don't see other tasks showing much impact. > > I'll leave this for a few days, then turn on `--enable-preview`. OK, looks fine thanks! Once you switched `--enable-preview` on, you should no longer see stack traces like this in the profile: ``` 1.84% 209556 jdk.internal.misc.Unsafe#convEndian() at jdk.internal.misc.Unsafe#getIntUnaligned() at jdk.internal.misc.ScopedMemoryAccess#getIntUnalignedInternal() at jdk.internal.misc.ScopedMemoryAccess#getIntUnaligned() at java.nio.DirectByteBuffer#getInt() at java.nio.DirectByteBuffer#getInt() at org.apache.lucene.store.ByteBufferGuard#getInt() at org.apache.lucene.store.ByteBufferIndexInput$SingleBufferImpl#readInt() ``` They should be visible as calls from `MemorySegmentIndexInput` to `MemorySegment.get()`; `ByteBufferIndexInput` calling `DirectByteBuffer` and so on should diappear. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
