dweiss commented on issue #11771:
URL: https://github.com/apache/lucene/issues/11771#issuecomment-1256892005
If this code went in the main branch then it's also a bug there. Comparing
strings by reference is a no-no - I should have caught it earlier. I'll do the
update on both branches late
romseygeek commented on PR #11807:
URL: https://github.com/apache/lucene/pull/11807#issuecomment-1256931459
I thought the changes you made for unrecognized queries fixed the issues
with the surround query parser? If not it would be good to implement query
visitors for the queries that it pr
romseygeek merged PR #11808:
URL: https://github.com/apache/lucene/pull/11808
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.
dweiss commented on PR #11810:
URL: https://github.com/apache/lucene/pull/11810#issuecomment-1256938048
This stream is not required at all: you just split on any consecutive
sequence of white spaces, including newlines, and it'll be fine. I'll commit
this separately and backport.
--
This
dweiss closed pull request #11810: fix equality check bug in test
URL: https://github.com/apache/lucene/pull/11810
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
dweiss closed issue #11771: KeywordRepeatFilter + OpenNLPLemmatizer Early Exit
URL: https://github.com/apache/lucene/issues/11771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
dweiss commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256959688
Not sure what's failing here, will take a look later. I suspect errorprone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHu
rmuir opened a new pull request, #11813:
URL: https://github.com/apache/lucene/pull/11813
This method is recursive: to avoid eating too much stack we apply a small
limit. This means it can't really be used on any largish automata without
hitting exception.
But the benefit of knowing
dweiss merged PR #11811:
URL: https://github.com/apache/lucene/pull/11811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
rmuir commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256971988
Looks like error-prone fails saying that `PublicConstructorForAbstractClass`
is not a valid checker name.
We explicitly disable it currently:
```
gradle/validation/error-prone.gra
dweiss commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256973107
Yeah, thanks, Robert. I'll be looking into this - have an hour to spare at
the airport anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, pl
stefanvodita opened a new issue, #11814:
URL: https://github.com/apache/lucene/issues/11814
### Description
`IndexRearranger` applies deletes found in the original index, so the
rearranged index will not contain any deleted docs. While deleted docs don't
show up in search results, th
dweiss commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256975233
Right - this check was removed here:
https://github.com/google/error-prone/commit/b4c6a03168102026bb6540627b21b356804250e4
--
This is an automated message from the Apache Git Service.
T
mikemccand commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979249444
##
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java:
##
@@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) {
dweiss commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256976327
Another check was removed here:
https://github.com/google/error-prone/pull/2809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
stefanvodita opened a new pull request, #11815:
URL: https://github.com/apache/lucene/pull/11815
### Description
Changes made to support deletes in `IndexRearranger`:
1. Add `isDeleted(LeafReader reader, int idx)` in document selectors, which
returns true if the document found at i
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979251049
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream repres
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979251445
##
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java:
##
@@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) {
}
mikemccand commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979251604
##
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java:
##
@@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) {
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979252083
##
lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java:
##
@@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) {
}
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979254120
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream repres
mikemccand commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979254281
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream r
rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979255164
##
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream repres
rmuir commented on PR #11813:
URL: https://github.com/apache/lucene/pull/11813#issuecomment-1256986744
I'm planning on doing this 10.x-only, not out of laziness, but because there
are already several related 10.x changes around this stuff: removal of det in
#11049, removal of minimize in #1
rmuir merged PR #11813:
URL: https://github.com/apache/lucene/pull/11813
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apach
rmuir closed issue #11809: input automaton is too large for lengthy wildcard
query
URL: https://github.com/apache/lucene/issues/11809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific co
rmuir commented on PR #11812:
URL: https://github.com/apache/lucene/pull/11812#issuecomment-1256988534
oh, one question @dweiss, since `javacc` is upgraded, should we force a
`gradlew regenerate`?
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
rmuir commented on issue #11809:
URL: https://github.com/apache/lucene/issues/11809#issuecomment-125699
Thanks for reporting this with easy-to-reproduce testcase @taroplus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
magibney commented on PR #11813:
URL: https://github.com/apache/lucene/pull/11813#issuecomment-1257009186
fwiw I have a local branch (very recent) that changed the implementation of
`Operations.isFinite()` (and `Operations.topoSortStates()`) to be
non-recursive, afaict without sacrificing p
shaie commented on code in PR #11768:
URL: https://github.com/apache/lucene/pull/11768#discussion_r979357774
##
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java:
##
@@ -189,10 +190,11 @@ private TopChildrenForPath
getTopChildrenForPath(DimConfig d
30 matches
Mail list logo