rmuir commented on code in PR #11813:
URL: https://github.com/apache/lucene/pull/11813#discussion_r979254120
##########
lucene/core/src/java/org/apache/lucene/analysis/AutomatonToTokenStream.java:
##########
@@ -46,10 +45,6 @@ private AutomatonToTokenStream() {}
* @return TokenStream representation of automaton.
*/
public static TokenStream toTokenStream(Automaton automaton) {
- if (Operations.isFinite(automaton) == false) {
Review Comment:
I looked at the javadocs (scroll up just a bit more), it looks good?
```java
/**
* converts an automaton into a TokenStream. This is done by first Topo
sorting the nodes in the
* Automaton. Nodes that have the same distance from the start are grouped
together to form the
* position nodes for the TokenStream. The resulting TokenStream releases
edges from the automaton
* as tokens in order from the position nodes. This requires the automaton
be a finite DAG.
*
* @param automaton automaton to convert. Must be a finite DAG.
* @return TokenStream representation of automaton.
*/
public static TokenStream toTokenStream(Automaton automaton) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
