mikemccand commented on code in PR #11813: URL: https://github.com/apache/lucene/pull/11813#discussion_r979251604
########## lucene/core/src/java/org/apache/lucene/util/automaton/CompiledAutomaton.java: ########## @@ -139,21 +136,21 @@ private static int findSinkState(Automaton automaton) { } /** - * Create this. If finite is null, we use {@link Operations#isFinite} to determine whether it is - * finite. If simplify is true, we run possibly expensive operations to determine if the automaton - * is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}. + * Create this. If simplify is true, we run possibly expensive operations to determine if the + * automaton is one the cases in {@link CompiledAutomaton.AUTOMATON_TYPE}. Set finite to true if + * the automaton is finite, otherwise set to false if infinite or you don't know. Review Comment: OK no worries -- no need to do more here! This change is already self-contained and a great progress! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org