jpountz commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r905820617
##
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##
@@ -439,29 +433,42 @@ private void set() {
static final class DocOrds {
final long
donnerpeter commented on PR #975:
URL: https://github.com/apache/lucene/pull/975#issuecomment-1165361337
@dweiss sure, no pressure, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
LuXugang commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r905872811
##
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##
@@ -415,34 +420,55 @@ public BytesRef lookupOrd(long ord) throws IOException {
publi
LuXugang commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r905873250
##
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##
@@ -439,29 +433,42 @@ private void set() {
static final class DocOrds {
final lon
LuXugang commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r905873478
##
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##
@@ -350,6 +354,8 @@ static class SortingSortedSetDocValues extends
SortedSetDocValues {
jpountz commented on code in PR #967:
URL: https://github.com/apache/lucene/pull/967#discussion_r905889905
##
lucene/core/src/java/org/apache/lucene/index/SortedSetDocValuesWriter.java:
##
@@ -114,6 +116,7 @@ private void finishCurrentDoc() {
}
lastValue = termID;
uschindler opened a new pull request, #976:
URL: https://github.com/apache/lucene/pull/976
This PR fixes the Eclipse task to exclude Lucene's own JAR files. I think
this problem was introduced when we switched to module system, previously the
project dependencies were just directories with
uschindler opened a new pull request, #977:
URL: https://github.com/apache/lucene/pull/977
See also issue: https://issues.apache.org/jira/browse/LUCENE-9500
This bug was fixed in JDK-16 (see
https://bugs.openjdk.org/browse/JDK-8252739) so it does not apply to main
branch (Java 17) an
[
https://issues.apache.org/jira/browse/LUCENE-9500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558427#comment-17558427
]
Uwe Schindler commented on LUCENE-9500:
---
I opened a PR to remove the fix on main b
uschindler opened a new pull request, #978:
URL: https://github.com/apache/lucene/pull/978
This PR deprecates (and we will remove them in main) some useless constants
in `oal.util.Constants`:
- JRE_IS_MINIMUM_JAVA_xxx (all are now return `true`)
- Runtime version and specification vers
uschindler commented on PR #976:
URL: https://github.com/apache/lucene/pull/976#issuecomment-1165506350
The reason for this fix is to remove:
- compile problems (sometimes it complains about duplicate class files).
This also leads to problems when some aleady compiled code does not get
r
dweiss commented on PR #976:
URL: https://github.com/apache/lucene/pull/976#issuecomment-1165514665
I'll take a look later today, Uwe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
uschindler merged PR #977:
URL: https://github.com/apache/lucene/pull/977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
iverase opened a new pull request, #979:
URL: https://github.com/apache/lucene/pull/979
This PR proposes to add a new method to SortedDocValues that helps users to
advance an iterator to the next document that contains a different term that
the current document, which can be specially usefu
[
https://issues.apache.org/jira/browse/LUCENE-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558472#comment-17558472
]
Adrien Grand commented on LUCENE-10624:
---
The code from SearchTaxis.java that you
[
https://issues.apache.org/jira/browse/LUCENE-10396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558474#comment-17558474
]
Ignacio Vera commented on LUCENE-10396:
---
I open a draft PR that shows the idea I
mhugo opened a new pull request, #2664:
URL: https://github.com/apache/lucene-solr/pull/2664
This is a backport of https://github.com/apache/lucene-solr/pull/2452 onto
8.11.
I currently use Lucene through Elasticsearch and am stuck for some time to
ES 7.17 that is shipped with Lucene
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558546#comment-17558546
]
Michael McCandless commented on LUCENE-10557:
-
{quote}Seems converting Jira
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558548#comment-17558548
]
Michael McCandless commented on LUCENE-10557:
-
I suppose we cannot ask GitH
javanna opened a new pull request, #980:
URL: https://github.com/apache/lucene/pull/980
I was digging on a failure triggered by concurrent search, made more likely
by LUCENE-10507, and I noticed some additional issues (beside the failure
itself which was quickly fixed by Adrien) with the te
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558558#comment-17558558
]
Michael McCandless commented on LUCENE-10557:
-
[~tomoko] could you share th
jpountz merged PR #980:
URL: https://github.com/apache/lucene/pull/980
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.
[
https://issues.apache.org/jira/browse/LUCENE-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558563#comment-17558563
]
ASF subversion and git services commented on LUCENE-10620:
--
Co
dweiss commented on PR #976:
URL: https://github.com/apache/lucene/pull/976#issuecomment-1165747736
Hi Uwe. This looks fine for me. Ideally, this should scan the dependencies
and exclude project dependency artifacts (this is possible) but it adds a whole
lot of code and achieves pretty much
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558576#comment-17558576
]
Tomoko Uchida commented on LUCENE-10557:
[~mikemccand] The script has been push
cpoerschke merged PR #820:
URL: https://github.com/apache/lucene/pull/820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558576#comment-17558576
]
Tomoko Uchida edited comment on LUCENE-10557 at 6/24/22 5:01 PM:
gsmiller commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1165780069
+1 to backporting to 9.x. I think we're ready to merge as far as I'm
concerned. @shaie I'll leave it to you to merge and backport, assuming you also
feel we're good-to-go here? If you'd pre
uschindler merged PR #976:
URL: https://github.com/apache/lucene/pull/976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apac
dweiss commented on code in PR #975:
URL: https://github.com/apache/lucene/pull/975#discussion_r906351080
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java:
##
@@ -340,9 +339,14 @@ public List analyzeSimpleWord(String word) {
return result
jtibshirani commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r906418634
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -121,36 +120,50 @@ public Query rewrite(IndexReader reader) throws
IOException {
retur
kaivalnp commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r906440432
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -121,36 +120,50 @@ public Query rewrite(IndexReader reader) throws
IOException {
return c
kaivalnp commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r906440936
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -121,36 +120,50 @@ public Query rewrite(IndexReader reader) throws
IOException {
return c
kaivalnp commented on code in PR #951:
URL: https://github.com/apache/lucene/pull/951#discussion_r906442078
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -121,36 +120,50 @@ public Query rewrite(IndexReader reader) throws
IOException {
return c
kaivalnp commented on PR #951:
URL: https://github.com/apache/lucene/pull/951#issuecomment-1166057877
As for the test, I saw that many existing ones use `BitSet` internally (for
example `testRandomWithFilter`) since it first caches into `LRUQueryCache` and
the `scorer` produces a `BitSetIte
[
https://issues.apache.org/jira/browse/LUCENE-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558700#comment-17558700
]
Greg Miller commented on LUCENE-10624:
--
For what it's worth, I ran a benchmark on
[
https://issues.apache.org/jira/browse/LUCENE-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558702#comment-17558702
]
Weiming Wu commented on LUCENE-10624:
-
Got it. Thanks again for the explanation and
[
https://issues.apache.org/jira/browse/LUCENE-10624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17558709#comment-17558709
]
Greg Miller commented on LUCENE-10624:
--
Oh, and just to clarify my above comment,
zacharymorn commented on PR #972:
URL: https://github.com/apache/lucene/pull/972#issuecomment-1166188875
Alright. As it turns out, the reason I'm getting vastly different
performance results as I change tasks file here
https://github.com/apache/lucene/pull/972#issuecomment-1163861983 is tha
donnerpeter commented on code in PR #975:
URL: https://github.com/apache/lucene/pull/975#discussion_r906636899
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordFormGenerator.java:
##
@@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (
donnerpeter commented on code in PR #975:
URL: https://github.com/apache/lucene/pull/975#discussion_r906636978
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordFormGenerator.java:
##
@@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (
donnerpeter commented on code in PR #975:
URL: https://github.com/apache/lucene/pull/975#discussion_r906637106
##
lucene/analysis/common/src/test/org/apache/lucene/analysis/hunspell/TestHunspell.java:
##
@@ -134,4 +138,32 @@ private Hunspell loadNoTimeout(String name) throws
Ex
donnerpeter commented on code in PR #975:
URL: https://github.com/apache/lucene/pull/975#discussion_r906637155
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordFormGenerator.java:
##
@@ -245,6 +240,31 @@ private LinkedHashSet appendFlags(AffixEntry
aff
donnerpeter commented on code in PR #975:
URL: https://github.com/apache/lucene/pull/975#discussion_r906637207
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordFormGenerator.java:
##
@@ -280,4 +300,188 @@ private boolean
isCompatibleWithPreviousAffixes
donnerpeter commented on code in PR #975:
URL: https://github.com/apache/lucene/pull/975#discussion_r906644498
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/Hunspell.java:
##
@@ -340,9 +339,14 @@ public List analyzeSimpleWord(String word) {
return r
dweiss commented on code in PR #975:
URL: https://github.com/apache/lucene/pull/975#discussion_r906645591
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/hunspell/WordFormGenerator.java:
##
@@ -0,0 +1,245 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
46 matches
Mail list logo
