dweiss commented on PR #976:
URL: https://github.com/apache/lucene/pull/976#issuecomment-1165747736

   Hi Uwe. This looks fine for me. Ideally, this should scan the dependencies 
and exclude project dependency artifacts (this is possible) but it adds a whole 
lot of code and achieves pretty much the same effect. I don't think the 
complexity is worth the gain here, as mentioned in the comment.
   ```
               // This is hacky - we take the resolved compile classpath and 
just
               // include JAR files from there. We should probably make it 
smarter
               // by looking at real dependencies. But then: this Eclipse 
configuration
               // doesn't really separate sources anyway so why bother.
               jars += prj.configurations.compileClasspath.resolve()
               jars += prj.configurations.testCompileClasspath.resolve() 
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to