zacharymorn commented on PR #972: URL: https://github.com/apache/lucene/pull/972#issuecomment-1166188875
Alright. As it turns out, the reason I'm getting vastly different performance results as I change tasks file here https://github.com/apache/lucene/pull/972#issuecomment-1163861983 is that, I have previously configured `SEARCH_NUM_THREADS = 10` in my `localconstants.py` and my changes somehow work better when more threads are executing disjunction queries at the same time. When the tasks file is unmodified and has more than 10 query tasks, the disjunction tasks get executed effectively serially; but when the tasks file only has 3 disjunction tasks, each task is executed multi-threaded. Here are the results with only 3 disjunction tasks with 3 queries each, but with different number of search threads: `SEARCH_NUM_THREADS = 10` ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value PKLookup 197.09 (18.1%) 202.07 (20.2%) 2.5% ( -30% - 49%) 0.678 OrHighLow 217.92 (28.3%) 433.05 (46.3%) 98.7% ( 18% - 241%) 0.000 OrHighHigh 12.53 (48.0%) 27.27 (64.9%) 117.7% ( 3% - 443%) 0.000 OrHighMed 14.09 (50.2%) 40.60 (74.8%) 188.1% ( 42% - 628%) 0.000 ``` `SEARCH_NUM_THREADS = 2` ``` TaskQPS baseline StdDevQPS my_modified_version StdDev Pct diff p-value OrHighLow 912.29 (12.1%) 903.58 (8.2%) -1.0% ( -18% - 22%) 0.771 PKLookup 252.26 (15.0%) 260.21 (15.5%) 3.2% ( -23% - 39%) 0.514 OrHighMed 70.16 (11.8%) 84.99 (8.9%) 21.1% ( 0% - 47%) 0.000 OrHighHigh 38.24 (11.9%) 49.09 (10.7%) 28.4% ( 5% - 57%) 0.000 ``` Just curious @jpountz , were you using the default `SEARCH_NUM_THREADS = 2` during your benchmark? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
