[GitHub] [lucene] jpountz commented on pull request #954: LUCENE-10603: Change iteration methodology for SSDV ordinals in the f…

2022-06-14 Thread GitBox
jpountz commented on PR #954: URL: https://github.com/apache/lucene/pull/954#issuecomment-1154822015 This is exactly the testing that I had in mind, thanks for running these benchmarks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [lucene] jpountz merged pull request #950: LUCENE-10608: Implement Weight#count on pure conjunctions.

2022-06-14 Thread GitBox
jpountz merged PR #950: URL: https://github.com/apache/lucene/pull/950 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.

[jira] [Commented] (LUCENE-10608) Implement Weight#count for pure conjunctions

2022-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553949#comment-17553949 ] ASF subversion and git services commented on LUCENE-10608: -- Co

[jira] [Commented] (LUCENE-10557) Migrate to GitHub issue from Jira?

2022-06-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553953#comment-17553953 ] Tomoko Uchida commented on LUCENE-10557: Vote thread: [https://lists.apache.or

[jira] [Commented] (LUCENE-10608) Implement Weight#count for pure conjunctions

2022-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553970#comment-17553970 ] ASF subversion and git services commented on LUCENE-10608: -- Co

[GitHub] [lucene] kaivalnp opened a new pull request, #958: LUCENE-10611: Fix Heap Error in HnswGraphSearcher

2022-06-14 Thread GitBox
kaivalnp opened a new pull request, #958: URL: https://github.com/apache/lucene/pull/958 ### Description Link to [Jira](https://issues.apache.org/jira/browse/LUCENE-10611) The HNSW graph search does not consider that visitedLimit may be reached in the upper levels of graph sear

[jira] [Commented] (LUCENE-10611) KnnVectorQuery throwing Heap Error for Restrictive Filters

2022-06-14 Thread Kaival Parikh (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553973#comment-17553973 ] Kaival Parikh commented on LUCENE-10611: Thanks, I have added the fix! As for t

[GitHub] [lucene] jpountz commented on pull request #950: LUCENE-10608: Implement Weight#count on pure conjunctions.

2022-06-14 Thread GitBox
jpountz commented on PR #950: URL: https://github.com/apache/lucene/pull/950#issuecomment-1154864922 Thanks @zhaih ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[jira] [Resolved] (LUCENE-10608) Implement Weight#count for pure conjunctions

2022-06-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adrien Grand resolved LUCENE-10608. --- Fix Version/s: 9.3 Resolution: Fixed > Implement Weight#count for pure conjunctions

[GitHub] [lucene] jpountz commented on a diff in pull request #907: LUCENE-10357 Ghost fields and postings/points

2022-06-14 Thread GitBox
jpountz commented on code in PR #907: URL: https://github.com/apache/lucene/pull/907#discussion_r896529395 ## lucene/codecs/src/java/org/apache/lucene/codecs/bloom/BloomFilteringPostingsFormat.java: ## @@ -200,8 +200,8 @@ public Terms terms(String field) throws IOException {

[jira] [Commented] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-14 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553987#comment-17553987 ] Lu Xugang commented on LUCENE-10600: Hi [~jpountz] ,should we also make SortedSetDo

[jira] [Commented] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-14 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553993#comment-17553993 ] Lu Xugang commented on LUCENE-10600: {quote}Is it that the unique count of ordinals

[jira] [Commented] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-14 Thread Adrien Grand (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554004#comment-17554004 ] Adrien Grand commented on LUCENE-10600: --- bq. should we also make SortedSetDocValu

[jira] [Created] (LUCENE-10616) Moving to dictionaries has made stored fields slower at skipping

2022-06-14 Thread Adrien Grand (Jira)
Adrien Grand created LUCENE-10616: - Summary: Moving to dictionaries has made stored fields slower at skipping Key: LUCENE-10616 URL: https://issues.apache.org/jira/browse/LUCENE-10616 Project: Lucene

[jira] [Resolved] (LUCENE-10615) Add license information for SmartChineseAnalyzer to NOTICE.txt

2022-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10615?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-10615. -- Resolution: Invalid Please don't use jira for questions like this. We won't be adding unneces

[jira] [Commented] (LUCENE-10615) Add license information for SmartChineseAnalyzer to NOTICE.txt

2022-06-14 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554039#comment-17554039 ] Dawid Weiss commented on LUCENE-10615: -- I think the reference you're looking for i

[jira] [Commented] (LUCENE-10615) Add license information for SmartChineseAnalyzer to NOTICE.txt

2022-06-14 Thread Jan Dornseifer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554067#comment-17554067 ] Jan Dornseifer commented on LUCENE-10615: - [~rcmuir] thanks for taking the time

[jira] [Commented] (LUCENE-10615) Add license information for SmartChineseAnalyzer to NOTICE.txt

2022-06-14 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554070#comment-17554070 ] Robert Muir commented on LUCENE-10615: -- > Please don't use jira for questions like

[jira] [Commented] (LUCENE-10615) Add license information for SmartChineseAnalyzer to NOTICE.txt

2022-06-14 Thread Jan Dornseifer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554072#comment-17554072 ] Jan Dornseifer commented on LUCENE-10615: - Where should such questions be asked

[jira] [Commented] (LUCENE-10615) Add license information for SmartChineseAnalyzer to NOTICE.txt

2022-06-14 Thread Tomoko Uchida (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554077#comment-17554077 ] Tomoko Uchida commented on LUCENE-10615: Hi, looks like the webpage (dead link)

[jira] [Comment Edited] (LUCENE-10612) Add parameters for HNSW codec in Lucene93Codec

2022-06-14 Thread Elia Porciani (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17553593#comment-17553593 ] Elia Porciani edited comment on LUCENE-10612 at 6/14/22 12:32 PM: ---

[jira] [Commented] (LUCENE-10615) Add license information for SmartChineseAnalyzer to NOTICE.txt

2022-06-14 Thread Jan Dornseifer (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554092#comment-17554092 ] Jan Dornseifer commented on LUCENE-10615: - [~tomoko] thanks for providing this

[GitHub] [lucene] msokolov commented on a diff in pull request #927: LUCENE-10151: Adding Timeout Support to IndexSearcher

2022-06-14 Thread GitBox
msokolov commented on code in PR #927: URL: https://github.com/apache/lucene/pull/927#discussion_r896898656 ## lucene/core/src/java/org/apache/lucene/search/IndexSearcher.java: ## @@ -766,18 +778,29 @@ protected void search(List leaves, Weight weight, Collector c }

[jira] [Resolved] (LUCENE-8193) Deprecate LowercaseTokenizer

2022-06-14 Thread Alan Woodward (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alan Woodward resolved LUCENE-8193. --- Resolution: Duplicate It is indeed a duplicate, thanks [~asalamon74]  > Deprecate Lowercase

[GitHub] [lucene] jtibshirani merged pull request #956: Make sure KnnVectorQuery applies search boost

2022-06-14 Thread GitBox
jtibshirani merged PR #956: URL: https://github.com/apache/lucene/pull/956 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apa

[jira] [Commented] (LUCENE-10612) Add parameters for HNSW codec in Lucene93Codec

2022-06-14 Thread Michael Sokolov (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554232#comment-17554232 ] Michael Sokolov commented on LUCENE-10612: -- > Actually, the change I'm proposi

[GitHub] [lucene] gsmiller commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
gsmiller commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897216959 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/ExactFacetSetMatcher.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [lucene] javanna opened a new pull request, #959: LUCENE-10507: Make it more likely to perform concurrent search in tests

2022-06-14 Thread GitBox
javanna opened a new pull request, #959: URL: https://github.com/apache/lucene/pull/959 I took a stab at this, these are the changes that I made: 1) Replace default useThreads value: rarely() -> randomBoolean() 2) apply lower slices thresholds more frequently: randomBoolean() -> fr

[GitHub] [lucene] vigyasharma commented on pull request #738: LUCENE-10448: Avoid instant rate write bursts by writing bytes buffer in chunks

2022-06-14 Thread GitBox
vigyasharma commented on PR #738: URL: https://github.com/apache/lucene/pull/738#issuecomment-1155751419 Based on @jpountz's response in [Lucene-10448](https://issues.apache.org/jira/browse/LUCENE-10448), looks like it is unusual for lucene to write byte[] arrays that are longer than the `

[GitHub] [lucene] shaie commented on pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1155985365 > but the one bigger question I'd like to discuss is how we envision handing different point types? I think there are two sides of supporting additional numeric types: indexing and aggr

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897533011 ## lucene/facet/docs/FacetSets.adoc: ## @@ -0,0 +1,90 @@ += FacetSets Overview +:toc: + +This document describes the `FacetSets` capability, which allows to aggregate on mul

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897535013 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897535157 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/MatchingFacetSetsCounts.java: ## @@ -0,0 +1,155 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [lucene] LuXugang merged pull request #957: LUCENE-10598: (backport) SortedSetDocValues#docValueCount() should be always greater than zero

2022-06-14 Thread GitBox
LuXugang merged PR #957: URL: https://github.com/apache/lucene/pull/957 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[jira] [Commented] (LUCENE-10598) SortedSetDocValues#docValueCount() should be always greater than zero

2022-06-14 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554367#comment-17554367 ] ASF subversion and git services commented on LUCENE-10598: -- Co

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897535559 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/RangeFacetSetMatcher.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one o

[jira] [Commented] (LUCENE-10600) SortedSetDocValues#docValueCount should be an int, not long

2022-06-14 Thread Lu Xugang (Jira)
[ https://issues.apache.org/jira/browse/LUCENE-10600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17554374#comment-17554374 ] Lu Xugang commented on LUCENE-10600: {quote}but this class is only used for flushes

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897538192 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/FacetSetsField.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897537151 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/FacetSetsField.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897537151 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/FacetSetsField.java: ## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [lucene] shaie commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

2022-06-14 Thread GitBox
shaie commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r897535976 ## lucene/facet/src/java/org/apache/lucene/facet/facetset/ExactFacetSetMatcher.java: ## @@ -0,0 +1,52 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [lucene] gautamworah96 commented on a diff in pull request #922: Index only the docs for FacetField posting list

2022-06-14 Thread GitBox
gautamworah96 commented on code in PR #922: URL: https://github.com/apache/lucene/pull/922#discussion_r897570270 ## lucene/facet/src/java/org/apache/lucene/facet/FacetField.java: ## @@ -30,14 +30,12 @@ */ public class FacetField extends Field { - /** Field type used for st

[GitHub] [lucene] gautamworah96 commented on pull request #922: Index only the docs for FacetField posting list

2022-06-14 Thread GitBox
gautamworah96 commented on PR #922: URL: https://github.com/apache/lucene/pull/922#issuecomment-1156032542 > I think we might be doing the right thing already? If you look at StringField, we are setting: setIndexOptions(IndexOptions.DOCS) Yes, that is indeed the case. Thanks fo

[jira] [Created] (LUCENE-10617) Investigate recent Jenkins build failures in TestMergeSchedulerExternal.testSubclassConcurrentMergeScheduler

2022-06-14 Thread Gautam Worah (Jira)
Gautam Worah created LUCENE-10617: - Summary: Investigate recent Jenkins build failures in TestMergeSchedulerExternal.testSubclassConcurrentMergeScheduler Key: LUCENE-10617 URL: https://issues.apache.org/jira/brows