kaivalnp opened a new pull request, #958:
URL: https://github.com/apache/lucene/pull/958

   ### Description
   
   Link to [Jira](https://issues.apache.org/jira/browse/LUCENE-10611)
   
   The HNSW graph search does not consider that visitedLimit may be reached in 
the upper levels of graph search itself
   
   This occurs when the pre-filter is too restrictive (and its count sets the 
visitedLimit). So instead of switching over to exactSearch, it tries to [pop 
from an empty 
heap](https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java#L90)
 and throws an error
   
   ### Solution
   
   We can check if results are incomplete after searching in upper levels, and 
break out accordingly. This way it won't throw heap errors, and gracefully 
switch to exactSearch instead


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to