craigtaverner opened a new pull request, #933:
URL: https://github.com/apache/lucene/pull/933
Fixes unable to tessellate complex polygon LUCENE-10563
https://issues.apache.org/jira/browse/LUCENE-10563
This issue included three polygons:
* Polygon-1 which jammed during tri
gsmiller commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1141887260
@shaie thanks for providing the use case doc. Very helpful!
As far as an API proposal, I really like the "facet set" concept for the
actual `Facets` implementation. Longer-term, I'd b
mocobeta commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r885435733
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -730,4 +774,79 @@ protected int comparePivot(int j) {
return Float.compare(score[pivo
mocobeta commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r885439874
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -730,4 +774,79 @@ protected int comparePivot(int j) {
return Float.compare(score[pivo
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida reassigned LUCENE-10557:
--
Assignee: Tomoko Uchida
> Migrate to GitHub issue from Jira?
> -
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544289#comment-17544289
]
Tomoko Uchida commented on LUCENE-10557:
Sure - it's not a big problem I think.
kaivalnp commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r885501069
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -730,4 +774,79 @@ protected int comparePivot(int j) {
return Float.compare(score[pivo
msokolov commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r885611627
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java:
##
@@ -109,12 +117,15 @@ public int[] nodes() {
/** Returns the top element's node id. */
p
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r885636403
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java:
##
@@ -109,12 +117,15 @@ public int[] nodes() {
/** Returns the top element's node
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r885637733
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -47,63 +42,30 @@ public float convertToScore(float similarity) {
DOT_PRO
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r885640429
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -245,11 +244,11 @@ private boolean diversityCheck(
NeighborArray neighbo
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r885641501
##
lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java:
##
@@ -193,25 +204,36 @@ public void testAdvanceShallow() throws IOException {
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r885643646
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -264,13 +263,13 @@ private int findWorstNonDiverse(NeighborArray neighbors)
th
LuXugang opened a new pull request, #934:
URL: https://github.com/apache/lucene/pull/934
See [LUCENE-10598](https://issues.apache.org/jira/browse/LUCENE-10598) .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r885670206
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswGraphBuilder.java:
##
@@ -51,7 +50,7 @@ public final class Lucene90Hns
alessandrobenedetti commented on PR #926:
URL: https://github.com/apache/lucene/pull/926#issuecomment-1142173916
Ok, so the two remaining points are:
1) is adding a division to
org.apache.lucene.index.VectorSimilarityFunction#compare a performance problem?
2) is the change of o
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r885670206
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswGraphBuilder.java:
##
@@ -51,7 +50,7 @@ public final class Lucene90Hns
msokolov commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r885693494
##
lucene/core/src/java/org/apache/lucene/search/KnnVectorQuery.java:
##
@@ -225,6 +225,11 @@ public BitSetIterator getIterator(int contextOrd) {
return new BitSetI
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1142206707
> Longer-term, I'd be more in favor of keeping the new field more generic
(e.g., a generic "points" doc values field that can be used for faceting but
also "slow" queries)
There are two
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544426#comment-17544426
]
Jan Høydahl commented on LUCENE-10557:
--
The "Project" grouping could for sure be u
msokolov commented on code in PR #927:
URL: https://github.com/apache/lucene/pull/927#discussion_r885712790
##
lucene/core/src/java/org/apache/lucene/search/TimeLimitingBulkScorer.java:
##
@@ -0,0 +1,66 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or mor
jpountz opened a new pull request, #935:
URL: https://github.com/apache/lucene/pull/935
With this change, segments are more likely to be considered for merging until
they reach the max merge size. Before this change, LogMergePolicy would
exclude
an entire window of `mergeFactor` segmen
[
https://issues.apache.org/jira/browse/LUCENE-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544438#comment-17544438
]
Mayya Sharipova commented on LUCENE-7398:
-
We are still experiencing this issue
[
https://issues.apache.org/jira/browse/LUCENE-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544438#comment-17544438
]
Mayya Sharipova edited comment on LUCENE-7398 at 5/31/22 2:51 PM:
[
https://issues.apache.org/jira/browse/LUCENE-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544438#comment-17544438
]
Mayya Sharipova edited comment on LUCENE-7398 at 5/31/22 2:51 PM:
[
https://issues.apache.org/jira/browse/LUCENE-7398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544438#comment-17544438
]
Mayya Sharipova edited comment on LUCENE-7398 at 5/31/22 2:52 PM:
madrob merged PR #2641:
URL: https://github.com/apache/lucene-solr/pull/2641
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
[
https://issues.apache.org/jira/browse/LUCENE-10574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Adrien Grand reopened LUCENE-10574:
---
Reopening: the change to LogMergePolicy isn't good.
The way that the change ignores unbalanced
madrob commented on PR #2637:
URL: https://github.com/apache/lucene-solr/pull/2637#issuecomment-1142310664
@zacharymorn I plan to cut 8.11.2 release soon, are you still interested in
this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
madrob commented on PR #2643:
URL: https://github.com/apache/lucene-solr/pull/2643#issuecomment-1142312071
Closing this one in favor of https://github.com/apache/solr/pull/875 and
then we can backport the results of that work when it lands.
--
This is an automated message from the Apache
madrob closed pull request #2643: SOLR-9359 Make Config API work for warming
queries
URL: https://github.com/apache/lucene-solr/pull/2643
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
madrob merged PR #2660:
URL: https://github.com/apache/lucene-solr/pull/2660
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.a
anshumg closed pull request #2649: Remove '-' between base.version and
version.suffix and change common-build to allow the new format
URL: https://github.com/apache/lucene-solr/pull/2649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
anshumg commented on PR #2649:
URL: https://github.com/apache/lucene-solr/pull/2649#issuecomment-1142343899
Sorry, missed the mention.
After thinking about this enough, I'm not comfortable merging this in -
thanks to everyone who reviewed and also got me to rethink my approach :)
-
jpountz opened a new pull request, #936:
URL: https://github.com/apache/lucene/pull/936
Originally I had tried to remove O(n^2) merging from LogMergePolicy using
the
same approach as for TieredMergePolicy, but this did not work well as it
fought
against invariants that LogMergePolicy
jpountz commented on code in PR #936:
URL: https://github.com/apache/lucene/pull/936#discussion_r885852033
##
lucene/test-framework/src/java/org/apache/lucene/tests/index/BaseMergePolicyTestCase.java:
##
@@ -328,21 +328,31 @@ public Set getPendingDeletions() throws
IOException
[
https://issues.apache.org/jira/browse/LUCENE-10564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated LUCENE-10564:
---
Fix Version/s: 8.11.2
> SparseFixedBitSet#or doesn't update memory accounting
> ---
msokolov commented on PR #924:
URL: https://github.com/apache/lucene/pull/924#issuecomment-1142390745
No comments here since @jtibshirani's 5 days ago, which I think I've
addressed, so I'll take that as consensus and push later today. Julie - I left
some of the minor refactoring changes in
mdmarshmallow commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1142403496
There was an email thread where some other commiters suggested also
developing this in sandbox. It does seem like this API could go through some
heavy changes (I think we all agree on
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1142433913
> Is there a benefit to having it in `facets` vs `sandbox`
I personally am not sure that we should worry about the big changes that the
module will go under. API-wise we tag the classes
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1142451787
I pushed a new package with the `FacetSet` API I had in mind. As I wrote
before, while thinking about it I realized that there are few issues to handle,
so I've decided to implement one of the
shaie commented on PR #841:
URL: https://github.com/apache/lucene/pull/841#issuecomment-1142455129
> As for creating a new multidimensional version of the `Facets` API, I
think what you're saying makes sense, but could we extend the existing `Facets`
API as well, I think those methods would
jtibshirani commented on code in PR #924:
URL: https://github.com/apache/lucene/pull/924#discussion_r885948710
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene92/Lucene92RWHnswVectorsFormat.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Softw
jtibshirani commented on code in PR #924:
URL: https://github.com/apache/lucene/pull/924#discussion_r885955544
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene92/Lucene92HnswVectorsFormat.java:
##
@@ -151,10 +131,6 @@ public KnnVectorsReader fieldsRead
mayya-sharipova commented on PR #926:
URL: https://github.com/apache/lucene/pull/926#issuecomment-1142595894
@alessandrobenedetti For measuring the performance impact, you can run [ann
benchmarks](https://github.com/msokolov/ann-benchmarks). I have a small
[change](https://github.com/msokol
msokolov commented on code in PR #924:
URL: https://github.com/apache/lucene/pull/924#discussion_r886117116
##
lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene92/Lucene92RWHnswVectorsFormat.java:
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the Apache Software
msokolov merged PR #924:
URL: https://github.com/apache/lucene/pull/924
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache
mocobeta commented on code in PR #932:
URL: https://github.com/apache/lucene/pull/932#discussion_r886226757
##
lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java:
##
@@ -730,4 +774,79 @@ protected int comparePivot(int j) {
return Float.compare(score[pivo
[
https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544657#comment-17544657
]
Tomoko Uchida commented on LUCENE-10557:
Thanks, it looks like a plain Kanban B
49 matches
Mail list logo
