gsmiller commented on PR #841: URL: https://github.com/apache/lucene/pull/841#issuecomment-1141887260
@shaie thanks for providing the use case doc. Very helpful! As far as an API proposal, I really like the "facet set" concept for the actual `Facets` implementation. Longer-term, I'd be more in favor of keeping the new field more generic (e.g., a generic "points" doc values field that can be used for faceting but also "slow" queries). But making it more general also makes it harder to understand for users that are just trying to use this faceting functionality. If we end up proposing this as a "sandbox" module feature for now, then I'd +1 this idea of a "facet set" API. If we propose adding this to the core functionality though, I'd like to further discuss the pros/cons of how specific we make this new doc values field. Thanks again! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
