Deepika0510 opened a new pull request, #927:
URL: https://github.com/apache/lucene/pull/927
### Problem Statement
Adding optional "timeout" capabilities to `IndexSearcher`. This would enable
users to (optionally) specify a maximum time budget for search execution. If
the search "times ou
msokolov commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883626055
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -47,63 +42,30 @@ public float convertToScore(float similarity) {
DOT_PRODUCT {
mocobeta closed pull request #923: LUCENE-10200: Correct outdated instruction
in the demo tutorial
URL: https://github.com/apache/lucene/pull/923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883687821
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java:
##
@@ -56,9 +56,9 @@ long apply(long v) {
// Whether the search stopped early because
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883689413
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java:
##
@@ -109,12 +117,15 @@ public int[] nodes() {
/** Returns the top element's node
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883695653
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -264,13 +263,13 @@ private int findWorstNonDiverse(NeighborArray neighbors)
th
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883696044
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -47,63 +42,30 @@ public float convertToScore(float similarity) {
DOT_PRO
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883696690
##
lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java:
##
@@ -109,12 +117,15 @@ public int[] nodes() {
/** Returns the top element's node
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883697041
##
lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java:
##
@@ -193,25 +204,36 @@ public void testAdvanceShallow() throws IOException {
[
https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542982#comment-17542982
]
Tomoko Uchida commented on LUCENE-10562:
Hi,
I would also recommend you not to
msokolov commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1139740650
I don't understand what happened here - I'm truly sorry if I somehow
(bikeshedding?) discouraged you from improving the instructions here; if it
wasn't clear: I thought what you had propose
mocobeta commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1139813850
I was just unsure where to go for improving it. There will be a better way
that does not overwhelm the readers of this tutorial with unfalimiar concepts
or too wordy descriptions, I haven't
mayya-sharipova commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883911186
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -47,63 +42,30 @@ public float convertToScore(float similarity) {
DOT_PRODUCT
dweiss commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-113873
Umm.. I agree with Mike, Tomoko - the improvement was there and evident. Can
we commit it in and maybe reiterate if we find a better wording in the future?
What you did was way better than it
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883955103
##
lucene/core/src/java/org/apache/lucene/index/VectorSimilarityFunction.java:
##
@@ -47,63 +42,30 @@ public float convertToScore(float similarity) {
DOT_PRO
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883956265
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphSearcher.java:
##
@@ -155,14 +155,14 @@ private NeighborQueue searchLevel(
// A bound that h
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883956772
##
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##
@@ -245,11 +244,11 @@ private boolean diversityCheck(
NeighborArray neighbo
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883957300
##
lucene/backward-codecs/src/java/org/apache/lucene/backward_codecs/lucene90/Lucene90HnswGraphBuilder.java:
##
@@ -51,7 +50,7 @@ public final class Lucene90Hns
alessandrobenedetti commented on code in PR #926:
URL: https://github.com/apache/lucene/pull/926#discussion_r883958913
##
lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java:
##
@@ -193,25 +208,40 @@ public void testAdvanceShallow() throws IOException {
vigyasharma commented on PR #633:
URL: https://github.com/apache/lucene/pull/633#issuecomment-1140109855
@mikemccand Thanks for beasting it and uncovering this issue!
I tried to do the same on my box but haven't had any luck so far. Any ideas
on how I can make it more likely to happen? H
mocobeta commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1140176391
I'm unsure if the change improves it. Thinking calmly there are two
questions in the change here.
1. The start commands for the demo app are no longer platform agnostic.
- The old
mocobeta commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1140180971
Also thank you both for your comments - at least I learned the subtle
difficulties related to launching commands (again).
--
This is an automated message from the Apache Git Service.
To r
22 matches
Mail list logo
