mocobeta commented on PR #923:
URL: https://github.com/apache/lucene/pull/923#issuecomment-1140176391
I'm unsure if the change improves it. Thinking calmly there are two
questions in the change here.
1. The start commands for the demo app are no longer platform agnostic.
- The old one works on any platform since it does not include any file
paths in it - it picks CLASSPATH environment variable.
2. Put all jars in a directory into classpath with `*` is not great.
- Old one says "Put all four of these files in your Java CLASSPATH." -
yes it's the correct way to encourage people to find necessary jars and
construct classpath on their own, except for the list of jars is obsoleted.
As we saw things seem not so obvious as I first thought, I would postpone it
for now; anyway it does not a big deal I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
