[GitHub] [lucene] mocobeta commented on pull request #920: LUCENE-10589: increase upper bound of test range query to the maximum value + 1

mocobeta commented on PR #920: URL: https://github.com/apache/lucene/pull/920#issuecomment-1136964941 I'll merge this, thanks for your quick response! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [lucene] mocobeta merged pull request #920: LUCENE-10589: increase upper bound of test range query to the maximum value + 1

mocobeta merged PR #920: URL: https://github.com/apache/lucene/pull/920 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache

[jira] [Commented] (LUCENE-10589) Fix corner case in TestKnnVectorQuery.testRandomWithFilter

[ https://issues.apache.org/jira/browse/LUCENE-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541898#comment-17541898 ] ASF subversion and git services commented on LUCENE-10589: -- Co

[jira] [Commented] (LUCENE-10589) Fix corner case in TestKnnVectorQuery.testRandomWithFilter

[ https://issues.apache.org/jira/browse/LUCENE-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541902#comment-17541902 ] ASF subversion and git services commented on LUCENE-10589: -- Co

[jira] [Resolved] (LUCENE-10589) Fix corner case in TestKnnVectorQuery.testRandomWithFilter

[ https://issues.apache.org/jira/browse/LUCENE-10589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tomoko Uchida resolved LUCENE-10589. Fix Version/s: 10.0 (main) 9.3 Resolution: Fixed > Fix corner c

[GitHub] [lucene] mocobeta commented on a diff in pull request #923: Replace classpath with modulepath in the demo tutorial

mocobeta commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881413568 ## lucene/demo/src/java/overview.html: ## @@ -49,36 +49,35 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applicatio

[GitHub] [lucene] mocobeta commented on pull request #923: LUCENE-10200: Replace classpath with modulepath in the demo tutorial

mocobeta commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137010121 I hooked this on LUCENE-10200 - actually, the tutorial has been obsoleted by the change in the way to assemble the binary distribution. Still, we can stick to classpath though, I feel lik

[jira] [Commented] (LUCENE-10200) Restructure and modernize the release artifacts

[ https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541987#comment-17541987 ] Tomoko Uchida commented on LUCENE-10200: Just wanted to leave a quick note. I h

[jira] [Created] (LUCENE-10591) Invalid character in SortableSingleDocSource.java

Andras Salamon created LUCENE-10591: --- Summary: Invalid character in SortableSingleDocSource.java Key: LUCENE-10591 URL: https://issues.apache.org/jira/browse/LUCENE-10591 Project: Lucene - Core

[GitHub] [lucene] asalamon74 opened a new pull request, #925: LUCENE-10591: Fix UTF-8 encoding

asalamon74 opened a new pull request, #925: URL: https://github.com/apache/lucene/pull/925 ### Description (or a Jira issue link if you have one) Fixing invalid UTF-8 characters in SortableSingleDocSource.java -- This is an automated message from the Apache Git Service. To respo

[GitHub] [lucene] msokolov commented on pull request #923: LUCENE-10200: Replace classpath with modulepath in the demo tutorial

msokolov commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137160783 Thanks for fixing those (pre-existing) typos. On the classpath/module path change I have mixed feelings. On the one hand, we should broadcast that we are now fully modularized and support u

[GitHub] [lucene] dweiss commented on pull request #923: LUCENE-10200: Replace classpath with modulepath in the demo tutorial

dweiss commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137165723 Modular are not new, they're just not widespread... I agree with @mocobeta that if you provide an explicit command line then there is little harm in not explaining all the options. The proble

[GitHub] [lucene] msokolov commented on a diff in pull request #873: LUCENE-10397: KnnVectorQuery doesn't tie break by doc ID

msokolov commented on code in PR #873: URL: https://github.com/apache/lucene/pull/873#discussion_r881581848 ## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborQueue.java: ## @@ -90,26 +92,34 @@ public boolean insertWithOverflow(int newNode, float newScore) { }

[GitHub] [lucene] mocobeta commented on pull request #923: LUCENE-10200: Replace classpath with modulepath in the demo tutorial

mocobeta commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137171363 Anyway the outdated instruction would need to be corrected. Maybe we can write both working commands for classpath and module path? Let me adjust it... -- This is an automated message

[GitHub] [lucene] msokolov commented on pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

msokolov commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137209317 > The problem with classpath is that you need to include all JARs individually this is handled much better by modules since you include the directory path (not each individual module JAR).

[GitHub] [lucene] mocobeta commented on a diff in pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

mocobeta commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881678572 ## lucene/demo/src/java/overview.html: ## @@ -49,40 +49,49 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applicatio

[GitHub] [lucene] mocobeta commented on pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

mocobeta commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137271336 I updated the text so that we have both working commands for module path and classpath in it. Please see the updated screenshot in the PR description to see how it looks, thanks. -- This

[jira] [Commented] (LUCENE-10590) Indexing all zero vectors leads to heat death of the universe

[ https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542068#comment-17542068 ] Michael Sokolov commented on LUCENE-10590: -- > Does the indexing logic rely on

[jira] [Comment Edited] (LUCENE-10590) Indexing all zero vectors leads to heat death of the universe

[ https://issues.apache.org/jira/browse/LUCENE-10590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542068#comment-17542068 ] Michael Sokolov edited comment on LUCENE-10590 at 5/25/22 2:09 PM: --

[GitHub] [lucene] msokolov commented on pull request #924: Create Lucene93 Codec and move Lucene92 to backwards_codecs

msokolov commented on PR #924: URL: https://github.com/apache/lucene/pull/924#issuecomment-1137306689 Thanks for the reminder about the unit tests - I will add. As for the approach of using a feature branch, I'm ambivalent. It seems better to me to separate out the "new codec version" commi

[GitHub] [lucene] dweiss commented on a diff in pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

dweiss commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881755153 ## lucene/demo/src/java/overview.html: ## @@ -49,40 +49,49 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applications

[GitHub] [lucene] dweiss commented on a diff in pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

dweiss commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881759841 ## lucene/demo/src/java/overview.html: ## @@ -49,40 +49,49 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applications

[GitHub] [lucene] mocobeta commented on a diff in pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

mocobeta commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881765516 ## lucene/demo/src/java/overview.html: ## @@ -49,40 +49,49 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applicatio

[GitHub] [lucene] mocobeta commented on a diff in pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

mocobeta commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881765516 ## lucene/demo/src/java/overview.html: ## @@ -49,40 +49,49 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applicatio

[GitHub] [lucene] mocobeta commented on a diff in pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

mocobeta commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881797523 ## lucene/demo/src/java/overview.html: ## @@ -49,40 +49,49 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applicatio

[GitHub] [lucene] mocobeta commented on a diff in pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

mocobeta commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881797523 ## lucene/demo/src/java/overview.html: ## @@ -49,40 +49,49 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applicatio

[GitHub] [lucene] mocobeta commented on pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

mocobeta commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137448834 I first thought it is sufficient to have a concrete working command for a Unix-like platform that based on module path, seems like things are not so obvious. I don't know what should I do h

[GitHub] [lucene] msokolov commented on pull request #924: Create Lucene93 Codec and move Lucene92 to backwards_codecs

msokolov commented on PR #924: URL: https://github.com/apache/lucene/pull/924#issuecomment-1137491647 I updated this PR so that: 1. the back-compat Lucene92 Codec no longer has the ability to write HNSW vector format 2. there are unit tests that verify we can still read the Lucene92 ve

[GitHub] [lucene] dweiss commented on a diff in pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

dweiss commented on code in PR #923: URL: https://github.com/apache/lucene/pull/923#discussion_r881886986 ## lucene/demo/src/java/overview.html: ## @@ -49,40 +49,49 @@ About the Demo demonstrates various functionalities of Lucene and how you can add Lucene to your applications

[GitHub] [lucene] mocobeta commented on pull request #923: LUCENE-10200: Correct outdated instruction in the demo tutorial

mocobeta commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137531284 Just a note... the thing I wanted to fix is, that the current tutorial has been outdated on many points - I don't think people can run the demo app without trials and error. Classpath v

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

mdmarshmallow commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r881945764 ## lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/LongPointFacetField.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (LUCENE-10557) Migrate to GitHub issue from Jira?

[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542180#comment-17542180 ] Tomoko Uchida commented on LUCENE-10557: We are having a long discuss thread on

[jira] [Comment Edited] (LUCENE-10557) Migrate to GitHub issue from Jira?

[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542180#comment-17542180 ] Tomoko Uchida edited comment on LUCENE-10557 at 5/25/22 6:27 PM:

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

mdmarshmallow commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r881945764 ## lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/LongPointFacetField.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [lucene] mdmarshmallow commented on a diff in pull request #841: LUCENE-10274: Add hyperrectangle faceting capabilities

mdmarshmallow commented on code in PR #841: URL: https://github.com/apache/lucene/pull/841#discussion_r881945764 ## lucene/facet/src/java/org/apache/lucene/facet/hyperrectangle/LongPointFacetField.java: ## @@ -0,0 +1,35 @@ +/* + * Licensed to the Apache Software Foundation (ASF)

[jira] [Comment Edited] (LUCENE-10557) Migrate to GitHub issue from Jira?

[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542180#comment-17542180 ] Tomoko Uchida edited comment on LUCENE-10557 at 5/25/22 6:31 PM:

[jira] [Comment Edited] (LUCENE-10557) Migrate to GitHub issue from Jira?

[ https://issues.apache.org/jira/browse/LUCENE-10557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542180#comment-17542180 ] Tomoko Uchida edited comment on LUCENE-10557 at 5/25/22 6:37 PM:

[jira] [Created] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

Mayya Sharipova created LUCENE-10592: Summary: Should we build HNSW graph on the fly during indexing Key: LUCENE-10592 URL: https://issues.apache.org/jira/browse/LUCENE-10592 Project: Lucene - Core

[jira] [Updated] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-10592: - Description: Currently, when we index vectors for KnnVectorField, we buffer those vecto

[jira] [Updated] (LUCENE-10592) Should we build HNSW graph on the fly during indexing

[ https://issues.apache.org/jira/browse/LUCENE-10592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mayya Sharipova updated LUCENE-10592: - Description: Currently, when we index vectors for KnnVectorField, we buffer those vecto

[GitHub] [lucene] mayya-sharipova commented on pull request #728: LUCENE-10194 Buffer KNN vectors on disk

mayya-sharipova commented on PR #728: URL: https://github.com/apache/lucene/pull/728#issuecomment-1137833962 @LuXugang Thanks for looking into this. I was thinking to close this issue and this PR. As @jtibshirani noted the problem with this approach is that flush or a segment creation may

[GitHub] [lucene-solr] kiranchitturi opened a new pull request, #2662: SOLR-16215 Escape query characters in Solr SQL Array UDF functions

kiranchitturi opened a new pull request, #2662: URL: https://github.com/apache/lucene-solr/pull/2662 * Backport of https://github.com/apache/solr/pull/879 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [lucene] jtibshirani commented on a diff in pull request #924: Create Lucene93 Codec and move Lucene92 to backwards_codecs

jtibshirani commented on code in PR #924: URL: https://github.com/apache/lucene/pull/924#discussion_r882189288 ## lucene/backward-codecs/src/test/org/apache/lucene/backward_codecs/lucene92/TestLucene92HnswVectorsFormat.java: ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Sof

[GitHub] [lucene] mikemccand merged pull request #925: LUCENE-10591: Fix UTF-8 encoding

mikemccand merged PR #925: URL: https://github.com/apache/lucene/pull/925 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apac

[jira] [Commented] (LUCENE-10591) Invalid character in SortableSingleDocSource.java

[ https://issues.apache.org/jira/browse/LUCENE-10591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542289#comment-17542289 ] ASF subversion and git services commented on LUCENE-10591: -- Co

[jira] [Commented] (LUCENE-10591) Invalid character in SortableSingleDocSource.java

[ https://issues.apache.org/jira/browse/LUCENE-10591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542290#comment-17542290 ] ASF subversion and git services commented on LUCENE-10591: -- Co

[jira] [Resolved] (LUCENE-10591) Invalid character in SortableSingleDocSource.java

[ https://issues.apache.org/jira/browse/LUCENE-10591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless resolved LUCENE-10591. - Fix Version/s: 10.0 (main) 9.3 Resolution: Fixed Than

[GitHub] [lucene] mikemccand commented on pull request #915: LUCENE-10585: Scrub copy/paste code in the facets module and attempt to simplify a bit

mikemccand commented on PR #915: URL: https://github.com/apache/lucene/pull/915#issuecomment-1138026556 Thank you @Yuti-G for running the dedicated `luceneutil` faceting benchmark! But: the `getAllDims` time for SSDV seems to have gotten much faster with this PR, which is great! Was

[jira] [Commented] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542341#comment-17542341 ] Ming Zhu commented on LUCENE-10562: --- I'm encountering a similar issue, but the impact

[jira] [Comment Edited] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542341#comment-17542341 ] Ming Zhu edited comment on LUCENE-10562 at 5/26/22 4:39 AM:

[jira] [Comment Edited] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542341#comment-17542341 ] Ming Zhu edited comment on LUCENE-10562 at 5/26/22 4:40 AM:

[jira] [Comment Edited] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542341#comment-17542341 ] Ming Zhu edited comment on LUCENE-10562 at 5/26/22 4:40 AM:

[jira] [Comment Edited] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542341#comment-17542341 ] Ming Zhu edited comment on LUCENE-10562 at 5/26/22 4:40 AM:

[jira] [Comment Edited] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542341#comment-17542341 ] Ming Zhu edited comment on LUCENE-10562 at 5/26/22 4:40 AM:

[jira] [Comment Edited] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542341#comment-17542341 ] Ming Zhu edited comment on LUCENE-10562 at 5/26/22 4:49 AM:

[jira] [Comment Edited] (LUCENE-10562) Large system: Wildcard search leads to full index scan despite filter query

[ https://issues.apache.org/jira/browse/LUCENE-10562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17542341#comment-17542341 ] Ming Zhu edited comment on LUCENE-10562 at 5/26/22 4:49 AM: