msokolov commented on PR #923: URL: https://github.com/apache/lucene/pull/923#issuecomment-1137160783
Thanks for fixing those (pre-existing) typos. On the classpath/module path change I have mixed feelings. On the one hand, we should broadcast that we are now fully modularized and support using module paths to declare dependencies on code. On the other hand, I don't even know how to "put jars on my module path" yet. Maybe I'm just a stick-in-the-mud, but modules still seems very new and I suspect many (most) Java devs probably haven't yet figured it out and are still using class-path? So, I'm not sure what that means for this documentation. It doesn't seem as if this is the right place to explain modules and class paths, but we want to make this accessible and easy to use. Maybe we could include both sets of directions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
