mocobeta merged pull request #771:
URL: https://github.com/apache/lucene/pull/771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513892#comment-17513892
]
ASF subversion and git services commented on LUCENE-10184:
--
Co
mocobeta commented on pull request #771:
URL: https://github.com/apache/lucene/pull/771#issuecomment-1081544897
Merged. Thank you for your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513900#comment-17513900
]
Adrien Grand commented on LUCENE-10184:
---
Thanks [~tomoko], these small things go
[
https://issues.apache.org/jira/browse/LUCENE-7634?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17513929#comment-17513929
]
Jeremy Liu commented on LUCENE-7634:
How about now? Can you use Lucene 9.0.0 on Andr
wjp719 commented on pull request #731:
URL: https://github.com/apache/lucene/pull/731#issuecomment-1081609232
@gautamworah96 thank you for your patient reviews. I have run the two new
added tests 2000 iterations and all passed.
@jpountz @iverase please help to review this pr, thanks
Jeremy Liu created LUCENE-10489:
---
Summary: Can I use Lucene9.0.0 or Lucene9.1.0 on Android project?
Key: LUCENE-10489
URL: https://issues.apache.org/jira/browse/LUCENE-10489
Project: Lucene - Core
BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r837310904
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r837310904
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
dweiss commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r837354373
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
assertEqu
[
https://issues.apache.org/jira/browse/LUCENE-10184?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10184.
Resolution: Fixed
> Move "how to contribute" documentation to the git repo
>
mocobeta merged pull request #772:
URL: https://github.com/apache/lucene/pull/772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr.
[
https://issues.apache.org/jira/browse/LUCENE-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514045#comment-17514045
]
ASF subversion and git services commented on LUCENE-10475:
--
Co
[
https://issues.apache.org/jira/browse/LUCENE-10475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tomoko Uchida resolved LUCENE-10475.
Fix Version/s: 10.0 (main)
Resolution: Fixed
> Reconsider package structure in kur
jpountz commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r837397382
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -163,6 +165,76 @@ public void visit(QueryVisitor visitor)
smoldenhauer-ish opened a new pull request #2651:
URL: https://github.com/apache/lucene-solr/pull/2651
fix: touchConfDir keeps current data at config node (SOLR-16110)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r837475991
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
BaurzhanSakhariev commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r837475991
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +163,43 @@ public void testInsertWithOverflow() {
mikemccand commented on a change in pull request #718:
URL: https://github.com/apache/lucene/pull/718#discussion_r837510411
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java
##
@@ -49,22 +57,24 @@ void rollup() throws IOException {
mikemccand commented on a change in pull request #762:
URL: https://github.com/apache/lucene/pull/762#discussion_r837531773
##
File path:
lucene/facet/src/test/org/apache/lucene/facet/taxonomy/directory/TestAlwaysRefreshDirectoryTaxonomyReader.java
##
@@ -0,0 +1,95 @@
+/*
+ *
[
https://issues.apache.org/jira/browse/LUCENE-10427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514145#comment-17514145
]
Suhan Mao commented on LUCENE-10427:
[~jpountz] Sorry for the late reply and thank
mikemccand commented on pull request #767:
URL: https://github.com/apache/lucene/pull/767#issuecomment-1082139269
> Quick question: shall I also merge existing test cases from
`TestNormsFieldExistsQuery`, `TestKnnVectorFieldExistsQuery` and
`TestDocValuesFieldExistsQuery` as well ?
gsmiller commented on a change in pull request #718:
URL: https://github.com/apache/lucene/pull/718#discussion_r837744334
##
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java
##
@@ -49,22 +57,24 @@ void rollup() throws IOException {
reta commented on pull request #749:
URL: https://github.com/apache/lucene/pull/749#issuecomment-1082488464
Thanks @jtibshirani
> I think this only fixes the problem if the documents have
SortedNumericDocValuesField but not NumericDocValuesField?
That is correct, only for `S
jtibshirani commented on pull request #749:
URL: https://github.com/apache/lucene/pull/749#issuecomment-1082501188
Thanks! I think `NumericDocValuesField` accepts floating point types as well
(see the `FloatDocValuesField` subclass for example). It is the single-valued
version of `SortedNu
reta commented on pull request #749:
URL: https://github.com/apache/lucene/pull/749#issuecomment-1082506007
> Thanks! I think `NumericDocValuesField` accepts floating point types as
well (see the `FloatDocValuesField` subclass for example). It is the
single-valued version of `SortedNumeric
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r838048975
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -163,6 +165,69 @@ public void visit(QueryVisitor visitor) {
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r838052200
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -163,6 +165,60 @@ public void visit(QueryVisitor visitor) {
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r838052074
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -314,6 +386,32 @@ public Scorer scorer(LeafReaderContext co
jtibshirani commented on pull request #749:
URL: https://github.com/apache/lucene/pull/749#issuecomment-1082549529
If I'm reading the logic right, it uses a different conversion though (like
`Float.floatToRawIntBits`) whereas `SortedNumericDocValuesField` expects
`NumericUtils.floatToSorta
jianping weng created LUCENE-10490:
--
Summary: Query implement Cloneable interface
Key: LUCENE-10490
URL: https://issues.apache.org/jira/browse/LUCENE-10490
Project: Lucene - Core
Issue Type:
[
https://issues.apache.org/jira/browse/LUCENE-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jianping weng updated LUCENE-10490:
---
Description: *Query* should implement *Cloneable* interface, so that
subClass of *Query* ca
wjp719 opened a new pull request #774:
URL: https://github.com/apache/lucene/pull/774
Query should implement Cloneable interface, so that subClass of Query can
clone itself to create a new instance when only minor modifications are needed
especially in Query#rewrite method.
Please r
wjp719 commented on a change in pull request #731:
URL: https://github.com/apache/lucene/pull/731#discussion_r838083031
##
File path:
lucene/sandbox/src/java/org/apache/lucene/sandbox/search/MultiRangeQuery.java
##
@@ -163,6 +165,76 @@ public void visit(QueryVisitor visitor) {
wjp719 commented on pull request #731:
URL: https://github.com/apache/lucene/pull/731#issuecomment-1082583137
@jpountz Hi, I have refactor the code according to your suggestions, please
review it again, thanks.
--
This is an automated message from the Apache Git Service.
To respond to t
dweiss commented on a change in pull request #770:
URL: https://github.com/apache/lucene/pull/770#discussion_r838137561
##
File path: lucene/core/src/test/org/apache/lucene/util/TestPriorityQueue.java
##
@@ -163,6 +164,57 @@ public void testInsertWithOverflow() {
assertEqu
jpountz commented on a change in pull request #767:
URL: https://github.com/apache/lucene/pull/767#discussion_r837740611
##
File path:
lucene/core/src/java/org/apache/lucene/search/DocValuesFieldExistsQuery.java
##
@@ -31,42 +28,21 @@
/**
* A {@link Query} that matches docu
[
https://issues.apache.org/jira/browse/LUCENE-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17514469#comment-17514469
]
Adrien Grand commented on LUCENE-10490:
---
Sorry I wasn't clear on my comment on LU
38 matches
Mail list logo
