gsmiller commented on a change in pull request #718:
URL: https://github.com/apache/lucene/pull/718#discussion_r837744334
##########
File path:
lucene/facet/src/java/org/apache/lucene/facet/taxonomy/FloatTaxonomyFacets.java
##########
@@ -49,22 +57,24 @@ void rollup() throws IOException {
if (ft.hierarchical && ft.multiValued == false) {
int dimRootOrd = taxoReader.getOrdinal(new FacetLabel(dim));
assert dimRootOrd > 0;
- values[dimRootOrd] += rollup(children[dimRootOrd]);
+ float newValue =
+ aggregationFunction.aggregate(values[dimRootOrd],
rollup(children[dimRootOrd]));
Review comment:
Right. More work needed to support MIN. I'll leave as TODO as you
suggest. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
