reta commented on pull request #749: URL: https://github.com/apache/lucene/pull/749#issuecomment-1082488464
Thanks @jtibshirani > I think this only fixes the problem if the documents have SortedNumericDocValuesField but not NumericDocValuesField? That is correct, only for `SortedNumericDocValuesField`, the `NumericDocValuesField` operates on `long` values only so it never runs into the same issue (luckily). > To me it'd be best to only tackle the main bug you ran into, the ClassCastException when using integers. To prevent errors when using double and float values, we could add an explicit check and disable the optimization in this case, and clarify in the javadoc that only LONG and INT are supported. Sure, I can do that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
